Skip to content

fixed number error in transfer-protocols example#323

Merged
ben merged 3 commits intoprogit:masterfrom
zwpaper:example_fix
Jul 6, 2015
Merged

fixed number error in transfer-protocols example#323
ben merged 3 commits intoprogit:masterfrom
zwpaper:example_fix

Conversation

@zwpaper
Copy link
Contributor

@zwpaper zwpaper commented Jun 26, 2015

I found the best way to fix the error is correcting the numbers, so I did it.

@zwpaper
Copy link
Contributor Author

zwpaper commented Jun 26, 2015

I delete a space and a line, I made a commit each line, review it please.

@ben
Copy link
Member

ben commented Jun 26, 2015

Apart from including the character, this looks great!

@zwpaper
Copy link
Contributor Author

zwpaper commented Jun 27, 2015

added a □ to indicate the '0x00', and happened to find another two mistaken. review it please.

BTW, is the order of '00009done' and '0000' in line 251 and 252 right?
In my opinion, the '0000' should be the end of a message, but here it shows up before the '0009done'.
I have try to catch the package, but the package is encrypted.
and in line 280, there is no '0009done', should it be like this?

excuse me for that I find nothing for the answer to this question, so that I have to ask here.

@zwpaper
Copy link
Contributor Author

zwpaper commented Jul 4, 2015

@ben I have find the answer in the source code of git, it should be

0009done
0000

I will update the PR, and the sample should be finally correct!

@ben
Copy link
Member

ben commented Jul 6, 2015

Beautiful. Thanks!

ben added a commit that referenced this pull request Jul 6, 2015
fixed number error in transfer-protocols example
@ben ben merged commit 23b7aa2 into progit:master Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants