Add PCISerialDevice (and 2x,4x)#2
Merged
raharper merged 3 commits intoproject-machine:mainfrom Jul 27, 2023
Merged
Conversation
ashwing123
force-pushed
the
PCI-serial-additions
branch
from
dfcab7e to
32d9b6f
Compare
raharper
reviewed
Jul 27, 2023
Collaborator
raharper
left a comment
raharper
left a comment
There was a problem hiding this comment.
Looks like we need to gofmt to codebase; we don't do golintci or such automatically. Let' me push up a PR to clean it up; and then you can rebase on top of that.
This allows the cloud init of ubuntu to appear on the console.
ashwing123
force-pushed
the
PCI-serial-additions
branch
from
32d9b6f to
e441215
Compare
raharper
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding pci-serial device allows the cloud init of ubuntu to connect to the console on aarch64 platforms.