Skip to content

Show loading spinner by All Rooms title above the rooms list #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinaboos merged 40 commits into from
Jul 28, 2025
Merged

Show loading spinner by All Rooms title above the rooms list #521

kevinaboos merged 40 commits into from
Jul 28, 2025

Conversation

@Guocork
Copy link
Contributor

@Guocork Guocork commented Jun 16, 2025 •
edited by alanpoon
Loading

Fixes #541

@ZhangHanDong ZhangHanDong added the blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature label Jun 24, 2025
@Guocork Guocork mentioned this pull request Jun 24, 2025
Closed
@kevinaboos
Copy link
Member

kevinaboos commented Jun 24, 2025

Why is this blocked on makepad? Which issue/feature is it blocked on?

@Guocork
Copy link
Contributor Author

Guocork commented Jun 25, 2025

Why is this blocked on makepad? Which issue/feature is it blocked on?

Now in makepad, the widget loading-spinner can't work, so i create a new loading-spinner widget and submit a pr 774, This PR is almost done — just waiting on the loading spinner, so now we're waiting for Makepad to merge it.

@kevinaboos
Copy link
Member

kevinaboos commented Jun 25, 2025

Thanks for clarifying. I left a comment there.

@kevinaboos
Copy link
Member

kevinaboos commented Jun 30, 2025 •
edited
Loading

Now in makepad, the widget loading-spinner can't work, so i create a new loading-spinner widget and submit a pr 774, This PR is almost done — just waiting on the loading spinner, so now we're waiting for Makepad to merge it.

your PR has been merged in! 👍

@kevinaboos kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature labels Jun 30, 2025
@Guocork Guocork marked this pull request as ready for review July 1, 2025 07:06
@Guocork
Copy link
Contributor Author

Guocork commented Jul 1, 2025

hello @kevinaboos I import the loading spinner, now this pr can be review.

@alanpoon
Copy link
Contributor

alanpoon commented Jul 2, 2025

There is now self.view.rooms_list(id!(rooms_list)).all_known_rooms_loaded() function to determine if all rooms have been loaded. There is no need usage of any actions. @Guocork Shall I take over this Issue?

@kevinaboos
Copy link
Member

kevinaboos commented Jul 2, 2025

There is now self.view.rooms_list(id!(rooms_list)).all_known_rooms_loaded() function to determine if all rooms have been loaded. There is no need usage of any actions. @Guocork Shall I take over this Issue?

We actually do still want the actions to be emitted by the sync status subscriber, since in the future we'll need those updates in the RoomScreen as well.

kevinaboos
kevinaboos requested changes Jul 2, 2025
View reviewed changes
alanpoon and others added 2 commits July 9, 2025 14:55
@alanpoon @kevinaboos
Restore AdaptiveView
fac22f5 
Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>
@alanpoon @kevinaboos
Move to SyncStatusAction
1c3cea9 
Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>
@alanpoon alanpoon self-assigned this Jul 9, 2025
@alanpoon alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Jul 10, 2025
kevinaboos
kevinaboos requested changes Jul 10, 2025
View reviewed changes
@alanpoon alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Jul 21, 2025
kevinaboos
kevinaboos requested changes Jul 21, 2025
View reviewed changes
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's just a little bit more refactoring that needs to happen, then we can merge it in.

@kevinaboos kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Jul 21, 2025
@alanpoon alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Jul 23, 2025
kevinaboos
kevinaboos requested changes Jul 23, 2025
View reviewed changes
Copy link
Member

@kevinaboos kevinaboos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, and is nearly ready to merge! I just left two small comments. Also, please resolve the merge conflicts, and then it'll be good to go. 👍

@kevinaboos kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Jul 23, 2025
@alanpoon alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Jul 28, 2025
@kevinaboos kevinaboos removed the waiting-on-review This issue is waiting to be reviewed label Jul 28, 2025
@kevinaboos kevinaboos merged commit 1e9d882 into project-robius:main Jul 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanpoon alanpoon alanpoon left review comments

@kevinaboos kevinaboos kevinaboos approved these changes

Assignees

@alanpoon alanpoon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show loading spinner under in rooms_list_header

4 participants

@Guocork @kevinaboos @alanpoon @ZhangHanDong