Reorganize the code into pkg and internal directories, this moves the oci directory out of stacker binary's way#335
Merged
rchincha merged 1 commit intoproject-stacker:mainfrom Dec 15, 2022
Conversation
ariel-miculas
force-pushed
the
rename-oci-dir
branch
from
1d14fd5 to
64e52fb
Compare
Contributor
|
I don't know that we can do this. At least it'll be painful for all the users of that path. Definitely major version change sort of thing. |
Contributor
|
Would organize code under pkg/ and internal/ if need be. That is the golang way to do this. |
ariel-miculas
force-pushed
the
rename-oci-dir
branch
from
64e52fb to
f862c74
Compare
ariel-miculas
requested review from
hallyn,
rchincha and
smoser
as code owners
ariel-miculas
force-pushed
the
rename-oci-dir
branch
4 times, most recently
from
64b34dd to
557d407
Compare
ariel-miculas
changed the title
Contributor
Author
|
@rchincha what do you think? |
rchincha
reviewed
Dec 8, 2022
ariel-miculas
force-pushed
the
rename-oci-dir
branch
2 times, most recently
from
2ca5d76 to
5e775ca
Compare
Contributor
|
@ariel-miculas can you resolve the conflict? you may just have to move that file again. |
ariel-miculas
force-pushed
the
rename-oci-dir
branch
from
5e775ca to
ca0e3dd
Compare
hallyn
approved these changes
Dec 14, 2022
Contributor
hallyn
left a comment
hallyn
left a comment
There was a problem hiding this comment.
Thank you. I like it. Much cleaner layout.
It'll still hurt for anyone using the pkg/ stuff right now, but it's worth it.
And, by switching to cmd/stacker/ you've made room for cmd/atomfs :)
Contributor
Author
|
This will need to be updated: https://stackerbuild.io/developer_guide/code_structure/ |
Contributor
|
@ariel-miculas can this wait until after #345, this being mostly a re-org PR. |
Contributor
Author
|
sure |
ariel-miculas
force-pushed
the
rename-oci-dir
branch
3 times, most recently
from
1a871ae to
15e3b72
Compare
This is done by reorganizing the code into the pkg directory. Files from cmd/ were also moved to cmd/stacker, according to the go guidelines. Fixes project-stacker#296 Fixes project-stacker#332 Signed-off-by: Ariel Miculas <amiculas@cisco.com>
ariel-miculas
force-pushed
the
rename-oci-dir
branch
from
15e3b72 to
f73e072
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296
Fixes #332
Signed-off-by: Ariel Miculas ariel.miculas@cisco.com