feat(build): add a substitute-file option#355
Merged
rchincha merged 1 commit intoproject-stacker:mainfrom Dec 9, 2022
Merged
Conversation
Contributor
|
Oh, nice, yes I've definitely wanted this, thanks. |
hallyn
approved these changes
Dec 9, 2022
Currently, all substitution args must be specified on command-line. Sometimes convenient to add them all in a file and read that file. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all substitution args must be specified on command-line. Sometimes convenient to add them all in a file and read that file.
Signed-off-by: Ramkumar Chinchani rchincha@cisco.com
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.