Reduce build and test dependency on docker:// urls.#357
Merged
rchincha merged 1 commit intoproject-stacker:mainfrom Dec 13, 2022
Merged
Reduce build and test dependency on docker:// urls.#357rchincha merged 1 commit intoproject-stacker:mainfrom
rchincha merged 1 commit intoproject-stacker:mainfrom
Conversation
smoser
force-pushed
the
feature/less-docker-io-dep
branch
from
6572063 to
e73e18a
Compare
hallyn
approved these changes
Dec 12, 2022
Dependance on docker:// urls are painful because of docker quotas.
At my large corporation, the docker.io quota is spent most of the
time by afternoon.
Currently, stacker build/check depends on docker.io (docker://) urls
in these places:
* build uses docker://alpine:edge - this can already be set via
STACKER_BUILD_BASE_IMAGE to some other alpine url.
* docker://centos:latest - now can be set in STACKER_DOCKER_BASE_CENTOS
* docker://ubuntu:latest - now can be set in STACKER_DOCKER_BASE_UBUNTU
The change here allows these urls to be configured as a group by
setting STACKER_DOCKER_BASE such as one of these:
make STACKER_DOCKER_BASE=docker://your-local-zot/stacker-deps/
make STACKER_DOCKER_BASE=oci:/data/sdeps:
or individually like:
make STACKER_BUILD_BASE_IMAGE=docker://alpine:edge \
STACKER_BUILD_UBUNTU_IMAGE=oci://data/sdeps:ubuntu:latest
Note: This does not address the issue with depending on "latest" anything,
in that the developer of those images can legitimately change their
behavior at any point. Using 'latest' is explicitly opting in for
breakage over time.
Signed-off-by: Scott Moser <scmoser@cisco.com>
smoser
force-pushed
the
feature/less-docker-io-dep
branch
from
e73e18a to
9ab6a11
Compare
andaaron
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependance on docker:// urls are painful because of docker quotas. At my large corporation, the docker.io quota is spent most of the time by afternoon.
Currently, stacker build/check depends on docker.io (docker://) urls in these places:
The change here allows these urls to be configured as a group by setting STACKER_DOCKER_BASE such as one of these:
or individually like:
Note: This does not address the issue with depending on "latest" anything, in that the developer of those images can legitimately change their behavior at any point. Using 'latest' is explicitly opting in for breakage over time.