Fix: MilkdropShader - ignore code comments (#958 / master)#978
Open
mbaetgen-wup wants to merge 1 commit intoprojectM-visualizer:masterfrom
Open
Fix: MilkdropShader - ignore code comments (#958 / master)#978mbaetgen-wup wants to merge 1 commit intoprojectM-visualizer:masterfrom
mbaetgen-wup wants to merge 1 commit intoprojectM-visualizer:masterfrom
Conversation
mbaetgen-wup
force-pushed
the
bugfix/handle-parser-comments-master
branch
from
f13e3cd to
537cf07
Compare
mbaetgen-wup
force-pushed
the
bugfix/handle-parser-comments-master
branch
from
537cf07 to
bd41e69
Compare
kblaschke
approved these changes
Mar 10, 2026
Member
kblaschke
left a comment
kblaschke
left a comment
There was a problem hiding this comment.
Hard to review on my small mobile display, but looks good and should do the trick.
Also great to see so many unit tests as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #958