Cannot build on debian

[wydwww]

I followed the debian doc
First, I can't apt-get install python-pylint, then I tried apt-get install pylint, it worked.

Then make install failed, log was:
#make install
/usr/bin/python setup.py build
Traceback (most recent call last):
File "setup.py", line 5, in
import Atomic as _Atomic
File "/home/ywang/atomic/Atomic/init.py", line 3, in
from .atomic import Atomic
File "/home/ywang/atomic/Atomic/atomic.py", line 6, in
from .syscontainers import SystemContainers
File "/home/ywang/atomic/Atomic/syscontainers.py", line 22, in
gi.require_version('OSTree', '1.0')
AttributeError: 'module' object has no attribute 'require_version'
Makefile:37: recipe for target 'python-build' failed
make: *** [python-build] Error 1

It looks like #409. I tried to comment out line 22 in syscontainers.py, but will have other pylint problems.

Thanks a lot if you could help me.

--

Edit：
I tried enkore/i3pystatus#314 and sdrelton/cryptocoin-indicator#4 and installed sudo apt install python-gobject, but still same error.

[wydwww]

I tried to install on another debian machine, and make install finally got:

Messages

+-----------------+------------+
|message id |occurrences |
+=================+============+
|bad-option-value |9 |
+-----------------+------------+

Global evaluation

Your code has been rated at 9.96/10 (previous run: 9.95/10, +0.00)

Makefile:41: recipe for target 'pylint-check' failed
make: *** [pylint-check] Error 2

I checked this pylint error should already fixed?

[ashcrow]

Apologies for the time between a response.

First, I can't apt-get install python-pylint, then I tried apt-get install pylint, it worked.

This is likely difference between the package names between Fedora and Debian and the Fedora name snuck in. It looks like the Debian package is indeed pylint or pylint3

The referenced document also seems to be missing:

• python-slip
• python-slip-dbus
• python-gobject

And I'm going to guess the gi.require_version('OSTree', '1.0') error you noticed is related to not having ostree installed.

Hopefully that helps. If the above packages end up getting you to a point you can install without problem please let me know (and I'll update the referenced doc) or, even better, update the doc and send it as a PR with a reference to me for review 😄.

[wydwww]

@ashcrow Thanks for response.
I updated this git repo, installed all these packages and ostree, but still no luck.
Same error:

ywang@ip-192-168-2-110:~/atomic$ make install
/usr/bin/python setup.py build
Traceback (most recent call last):
  File "setup.py", line 5, in <module>
    import Atomic as _Atomic
  File "/home/ywang/atomic/Atomic/__init__.py", line 3, in <module>
    from .atomic import Atomic
  File "/home/ywang/atomic/Atomic/atomic.py", line 6, in <module>
    from .syscontainers import SystemContainers
  File "/home/ywang/atomic/Atomic/syscontainers.py", line 23, in <module>
    gi.require_version('OSTree', '1.0')
AttributeError: 'module' object has no attribute 'require_version'
Makefile:37: recipe for target 'python-build' failed
make: *** [python-build] Error 1

[ashcrow]

@wydwww can you provide the output of:

$ python -c "import gi; print(dir(gi))"

It should look like:

['PyGIDeprecationWarning', 'PyGIWarning', 'Repository', '_API', '_DummyStaticModule', '__builtins__', '__doc__', '__file__', '__name__', '__package__', '__path__', '__version__', '_error', '_gi', '_gobject', '_overridesdir', '_static_binding_error', '_versions', 'absolute_import', 'check_version', 'extend_path', 'get_required_version', 'importlib', 'os', 'require_foreign', 'require_version', 'require_versions', 'sys', 'types', 'version_info']

unless you are getting the wrong gi library via pip. In #1135 I removed gi from requirements.txt to avoid this problem when using pip.

[ashcrow]

@wydwww also note it looks like gi is split out into a different package in Debian: python-gi.

[wydwww]

After I pip uninstall gi and use python-gi, the output of this script is same with yours. Looks like this problem fixed. Thanks.

Now comes the error I mentioned in my second comment previously.
I'm still confused about this, can you please help me look at this?
The error message is:

ywang@ip-192-168-2-110:~/atomic$ make install
/usr/bin/python setup.py build
running build
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/Atomic
copying Atomic/verify.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/rpmwriter.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/Export.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/help.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/backendutils.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/scan.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/trust.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/stop.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/install.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/pull.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/rpm_host_install.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/storage.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/sign.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/discovery.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/Import.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/info.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/tag.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/top.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/host.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/delete.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/atomic.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/util.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/containers.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/update.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/__init__.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/push.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/syscontainers.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/diff.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/uninstall.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/run.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/client.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/pulp.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/images.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/mount.py -> build/lib.linux-x86_64-2.7/Atomic
copying Atomic/satellite.py -> build/lib.linux-x86_64-2.7/Atomic
creating build/lib.linux-x86_64-2.7/Atomic/backends
copying Atomic/backends/_containers_storage.py -> build/lib.linux-x86_64-2.7/Atomic/backends
copying Atomic/backends/_docker_errors.py -> build/lib.linux-x86_64-2.7/Atomic/backends
copying Atomic/backends/_ostree.py -> build/lib.linux-x86_64-2.7/Atomic/backends
copying Atomic/backends/_docker.py -> build/lib.linux-x86_64-2.7/Atomic/backends
copying Atomic/backends/backend.py -> build/lib.linux-x86_64-2.7/Atomic/backends
copying Atomic/backends/__init__.py -> build/lib.linux-x86_64-2.7/Atomic/backends
creating build/lib.linux-x86_64-2.7/Atomic/objects
copying Atomic/objects/image.py -> build/lib.linux-x86_64-2.7/Atomic/objects
copying Atomic/objects/container.py -> build/lib.linux-x86_64-2.7/Atomic/objects
copying Atomic/objects/__init__.py -> build/lib.linux-x86_64-2.7/Atomic/objects
copying Atomic/objects/layer.py -> build/lib.linux-x86_64-2.7/Atomic/objects
running build_scripts
creating build/scripts-2.7
copying and adjusting atomic -> build/scripts-2.7
copying and adjusting atomic_dbus.py -> build/scripts-2.7
changing mode of build/scripts-2.7/atomic from 644 to 755
changing mode of build/scripts-2.7/atomic_dbus.py from 644 to 755
/usr/bin/go-md2man -in docs/atomic-containers.1.md -out docs/atomic-containers.1.tmp && touch docs/atomic-containers.1.tmp && mv docs/atomic-containers.1.tmp docs/atomic-containers.1
/usr/bin/go-md2man -in docs/atomic-diff.1.md -out docs/atomic-diff.1.tmp && touch docs/atomic-diff.1.tmp && mv docs/atomic-diff.1.tmp docs/atomic-diff.1
/usr/bin/go-md2man -in docs/atomic-install.1.md -out docs/atomic-install.1.tmp && touch docs/atomic-install.1.tmp && mv docs/atomic-install.1.tmp docs/atomic-install.1
/usr/bin/go-md2man -in docs/atomic-stop.1.md -out docs/atomic-stop.1.tmp && touch docs/atomic-stop.1.tmp && mv docs/atomic-stop.1.tmp docs/atomic-stop.1
/usr/bin/go-md2man -in docs/atomic.1.md -out docs/atomic.1.tmp && touch docs/atomic.1.tmp && mv docs/atomic.1.tmp docs/atomic.1
/usr/bin/go-md2man -in docs/atomic-host.1.md -out docs/atomic-host.1.tmp && touch docs/atomic-host.1.tmp && mv docs/atomic-host.1.tmp docs/atomic-host.1
/usr/bin/go-md2man -in docs/atomic-run.1.md -out docs/atomic-run.1.tmp && touch docs/atomic-run.1.tmp && mv docs/atomic-run.1.tmp docs/atomic-run.1
/usr/bin/go-md2man -in docs/atomic-help.1.md -out docs/atomic-help.1.tmp && touch docs/atomic-help.1.tmp && mv docs/atomic-help.1.tmp docs/atomic-help.1
/usr/bin/go-md2man -in docs/atomic-sign.1.md -out docs/atomic-sign.1.tmp && touch docs/atomic-sign.1.tmp && mv docs/atomic-sign.1.tmp docs/atomic-sign.1
/usr/bin/go-md2man -in docs/atomic-images.1.md -out docs/atomic-images.1.tmp && touch docs/atomic-images.1.tmp && mv docs/atomic-images.1.tmp docs/atomic-images.1
/usr/bin/go-md2man -in docs/atomic-unmount.1.md -out docs/atomic-unmount.1.tmp && touch docs/atomic-unmount.1.tmp && mv docs/atomic-unmount.1.tmp docs/atomic-unmount.1
/usr/bin/go-md2man -in docs/atomic-push.1.md -out docs/atomic-push.1.tmp && touch docs/atomic-push.1.tmp && mv docs/atomic-push.1.tmp docs/atomic-push.1
/usr/bin/go-md2man -in docs/atomic-scan.1.md -out docs/atomic-scan.1.tmp && touch docs/atomic-scan.1.tmp && mv docs/atomic-scan.1.tmp docs/atomic-scan.1
/usr/bin/go-md2man -in docs/atomic-mount.1.md -out docs/atomic-mount.1.tmp && touch docs/atomic-mount.1.tmp && mv docs/atomic-mount.1.tmp docs/atomic-mount.1
/usr/bin/go-md2man -in docs/atomic-top.1.md -out docs/atomic-top.1.tmp && touch docs/atomic-top.1.tmp && mv docs/atomic-top.1.tmp docs/atomic-top.1
/usr/bin/go-md2man -in docs/atomic-trust.1.md -out docs/atomic-trust.1.tmp && touch docs/atomic-trust.1.tmp && mv docs/atomic-trust.1.tmp docs/atomic-trust.1
/usr/bin/go-md2man -in docs/atomic-pull.1.md -out docs/atomic-pull.1.tmp && touch docs/atomic-pull.1.tmp && mv docs/atomic-pull.1.tmp docs/atomic-pull.1
/usr/bin/go-md2man -in docs/atomic-uninstall.1.md -out docs/atomic-uninstall.1.tmp && touch docs/atomic-uninstall.1.tmp && mv docs/atomic-uninstall.1.tmp docs/atomic-uninstall.1
/usr/bin/go-md2man -in docs/atomic-storage.1.md -out docs/atomic-storage.1.tmp && touch docs/atomic-storage.1.tmp && mv docs/atomic-storage.1.tmp docs/atomic-storage.1
/usr/bin/python -m pylint --disable=all --enable=E --enable=W --additional-builtins=_ *.py atomic Atomic tests/unit/*.py -d=no-absolute-import,print-statement,no-absolute-import,bad-builtin,catching-non-exception,raising-non-exception
No config file found, using default configuration
************* Module Atomic.stop
E: 31, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.sign
E: 46, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.host
E:111, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.update
E: 33, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.syscontainers
E: 10, 0: Bad option value 'bad-python3-import' (bad-option-value)
************* Module Atomic.uninstall
E: 45, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.mount
E:131, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.objects.image
E: 10, 0: Bad option value 'eq-without-hash' (bad-option-value)
************* Module Atomic.objects.layer
E:  4, 0: Bad option value 'eq-without-hash' (bad-option-value)


Report
======
10099 statements analysed.

Statistics by type
------------------

+---------+-------+-----------+-----------+------------+---------+
|type     |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module   |54     |54         |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|class    |81     |81         |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|method   |803    |800        |+3.00      |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|function |168    |168        |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+



External dependencies
---------------------
::

    Atomic (atomic_dbus,Atomic.update,Atomic.install,Atomic.sign,Atomic.mount,Atomic.scan,Atomic.diff,Atomic.backends._docker,Atomic.stop,Atomic.top,Atomic.pull,Atomic.delete,Atomic.run,Atomic.images,Atomic.help,Atomic.containers,Atomic.trust,Atomic.info,Atomic.verify,Atomic.uninstall,Atomic.tag,Atomic.storage,Atomic.push,setup,Atomic.host,atomic)
      \-Export (Atomic.storage)
      \-Import (Atomic.storage)
      \-atomic (Atomic.push,Atomic.backends._docker,Atomic.update,Atomic.storage,Atomic.info,Atomic.install,Atomic.pull,Atomic.uninstall,Atomic.run,Atomic.stop,Atomic.host)
      \-backends
      | \-_containers_storage (Atomic.backendutils)
      | \-_docker (Atomic.backendutils,Atomic.run)
      | \-_docker_errors (Atomic.mount,Atomic.syscontainers,Atomic.backends._docker,Atomic.util,Atomic.atomic,Atomic.top,atomic,Atomic.client,Atomic.backendutils,Atomic.storage)
      | \-_ostree (Atomic.backendutils,Atomic.uninstall)
      | \-backend (Atomic.backends._containers_storage,Atomic.backends._ostree,Atomic.backends._docker)
      \-backendutils (Atomic.uninstall,Atomic.mount,Atomic.scan,Atomic.update,Atomic.pull,Atomic.util,Atomic.containers,Atomic.info,Atomic.install,Atomic.verify,Atomic.delete,Atomic.run,Atomic.images,Atomic.tag,Atomic.stop)
      \-client (Atomic.objects.image,Atomic.syscontainers,Atomic.diff,Atomic.backends._docker,Atomic.util,Atomic.containers,Atomic.Export,Atomic.atomic,Atomic.verify,Atomic.objects.layer)
      \-containers (atomic,atomic_dbus)
      \-delete (Atomic.images,atomic_dbus)
      \-diff (test_diff,atomic,atomic_dbus)
      \-discovery (Atomic.objects.image,Atomic.backends._docker,Atomic.util,Atomic.info,Atomic.atomic,Atomic.install,Atomic.verify,Atomic.run,Atomic.sign,test_discovery)
      \-help (Atomic.images,atomic,atomic_dbus)
      \-host (atomic)
      \-images (atomic,atomic_dbus)
      \-info (Atomic.images,atomic,atomic_dbus)
      \-install (Atomic.uninstall,atomic,atomic_dbus)
      \-mount (Atomic.scan,Atomic.images,Atomic.diff,Atomic.backends._docker,atomic_dbus,test_mount,Atomic.verify,atomic,Atomic.help)
      \-objects
      | \-container (Atomic.backends._containers_storage,Atomic.backends._ostree,Atomic.backends._docker)
      | \-image (Atomic.backends._containers_storage,Atomic.backends._ostree,Atomic.mount,Atomic.backends._docker)
      | \-layer (Atomic.backends._ostree,Atomic.objects.image,Atomic.backends._docker)
      \-pull (atomic,atomic_dbus)
      \-pulp (Atomic.push)
      \-push (atomic,atomic_dbus)
      \-rpm_host_install (Atomic.syscontainers,Atomic.backends._docker)
      \-rpmwriter (Atomic.rpm_host_install)
      \-run (atomic,atomic_dbus)
      \-satellite (Atomic.push)
      \-scan (atomic,atomic_dbus)
      \-sign (atomic,atomic_dbus)
      \-stop (atomic,atomic_dbus)
      \-storage (atomic,atomic_dbus)
      \-syscontainers (Atomic.backends._ostree,Atomic.mount,Atomic.containers,Atomic.atomic,Atomic.install,Atomic.verify)
      \-tag (Atomic.images,atomic_dbus)
      \-top (atomic,atomic_dbus)
      \-trust (Atomic.backends._containers_storage,test_trust,atomic,Atomic.backends._docker,atomic_dbus)
      \-uninstall (atomic,atomic_dbus)
      \-update (Atomic.images,atomic,atomic_dbus)
      \-util (atomic_dbus,Atomic.objects.image,Atomic.Export,Atomic.update,atomic,Atomic.sign,Atomic.backends._ostree,Atomic.mount,Atomic.scan,Atomic.diff,Atomic.backends._docker,Atomic.discovery,Atomic.storage,Atomic.pulp,Atomic.install,Atomic.rpm_host_install,Atomic.pull,Atomic.delete,Atomic.run,Atomic.objects.layer,Atomic.backendutils,atomic_dbus_client,Atomic.backends._containers_storage,Atomic.images,Atomic.help,Atomic.top,Atomic.containers,Atomic.trust,Atomic.info,Atomic.verify,Atomic.uninstall,Atomic.tag,Atomic.stop,test_discovery,Atomic.satellite,Atomic.syscontainers,test_util_sh,Atomic.push,Atomic.objects.container,test_trust,Atomic.atomic,Atomic.Import)
      \-verify (Atomic.images,atomic,atomic_dbus)
    dateutil
      \-parser (Atomic.backends._docker)
    dbus (atomic_dbus_client,atomic_dbus)
      \-mainloop
      | \-glib (atomic_dbus_client,atomic_dbus)
      \-service (atomic_dbus_client,atomic_dbus)
    docker (Atomic.mount,atomic,Atomic.client)
      \-errors (Atomic.containers,Atomic.atomic,Atomic.backends._docker,Atomic.diff)
    gi (Atomic.syscontainers)
      \-repository (Atomic.syscontainers,Atomic.mount,atomic_dbus)
    requests (Atomic.mount,Atomic.util,Atomic.trust,Atomic.atomic,Atomic.top,Atomic.pulp,Atomic.client,Atomic.storage,Atomic.satellite)
      \-exceptions (Atomic.backends._docker)
    rpm (Atomic.diff)
    selinux (Atomic.util,Atomic.storage)
    slip
      \-dbus
        \-polkit (atomic_dbus_client)
        \-service (atomic_dbus)
    urllib3 (Atomic.util)
    xattr (Atomic.mount)
    yaml (Atomic.util,test_trust,Atomic.trust)
      \-scanner (Atomic.util)



Raw metrics
-----------

+----------+-------+------+---------+-----------+
|type      |number |%     |previous |difference |
+==========+=======+======+=========+===========+
|code      |11240  |72.68 |11157    |+83.00     |
+----------+-------+------+---------+-----------+
|docstring |1518   |9.82  |1508     |+10.00     |
+----------+-------+------+---------+-----------+
|comment   |702    |4.54  |695      |+7.00      |
+----------+-------+------+---------+-----------+
|empty     |2006   |12.97 |1992     |+14.00     |
+----------+-------+------+---------+-----------+



Duplication
-----------

+-------------------------+------+---------+-----------+
|                         |now   |previous |difference |
+=========================+======+=========+===========+
|nb duplicated lines      |163   |163      |=          |
+-------------------------+------+---------+-----------+
|percent duplicated lines |1.058 |1.066    |-0.01      |
+-------------------------+------+---------+-----------+



Messages by category
--------------------

+-----------+-------+---------+-----------+
|type       |number |previous |difference |
+===========+=======+=========+===========+
|convention |0      |0        |=          |
+-----------+-------+---------+-----------+
|refactor   |0      |0        |=          |
+-----------+-------+---------+-----------+
|warning    |0      |0        |=          |
+-----------+-------+---------+-----------+
|error      |9      |9        |=          |
+-----------+-------+---------+-----------+



% errors / warnings by module
-----------------------------

+---------------------+------+--------+---------+-----------+
|module               |error |warning |refactor |convention |
+=====================+======+========+=========+===========+
|Atomic.update        |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.uninstall     |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.syscontainers |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.stop          |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.sign          |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.objects.layer |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.objects.image |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.mount         |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.host          |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+



Messages
--------

+-----------------+------------+
|message id       |occurrences |
+=================+============+
|bad-option-value |9           |
+-----------------+------------+



Global evaluation
-----------------
Your code has been rated at 9.96/10 (previous run: 9.96/10, +0.00)

Makefile:41: recipe for target 'pylint-check' failed
make: *** [pylint-check] Error 2
ywang@ip-192-168-2-110:~/atomic$ python -c "import gi; print(dir(gi))"
['PyGIDeprecationWarning', 'PyGIWarning', 'Repository', '_API', '_DummyStaticModule', '__builtins__', '__doc__', '__file__', '__name__', '__package__', '__path__', '__version__', '_error', '_gi', '_gobject', '_overridesdir', '_static_binding_error', '_versions', 'absolute_import', 'check_version', 'extend_path', 'get_required_version', 'importlib', 'os', 'require_foreign', 'require_version', 'require_versions', 'sys', 'types', 'version_info']
ywang@ip-192-168-2-110:~/atomic$ make install
/usr/bin/python setup.py build
running build
running build_py
running build_scripts
/usr/bin/python -m pylint --disable=all --enable=E --enable=W --additional-builtins=_ *.py atomic Atomic tests/unit/*.py -d=no-absolute-import,print-statement,no-absolute-import,bad-builtin,catching-non-exception,raising-non-exception
No config file found, using default configuration
************* Module Atomic.stop
E: 31, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.sign
E: 46, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.host
E:111, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.update
E: 33, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.syscontainers
E: 10, 0: Bad option value 'bad-python3-import' (bad-option-value)
************* Module Atomic.uninstall
E: 45, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.mount
E:131, 0: Bad option value 'useless-super-delegation' (bad-option-value)
************* Module Atomic.objects.image
E: 10, 0: Bad option value 'eq-without-hash' (bad-option-value)
************* Module Atomic.objects.layer
E:  4, 0: Bad option value 'eq-without-hash' (bad-option-value)


Report
======
10099 statements analysed.

Statistics by type
------------------

+---------+-------+-----------+-----------+------------+---------+
|type     |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module   |54     |54         |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|class    |81     |81         |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|method   |803    |803        |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+
|function |168    |168        |=          |NC          |NC       |
+---------+-------+-----------+-----------+------------+---------+



External dependencies
---------------------
::

    Atomic (atomic_dbus,Atomic.update,Atomic.install,Atomic.sign,Atomic.mount,Atomic.scan,Atomic.diff,Atomic.backends._docker,Atomic.stop,Atomic.top,Atomic.pull,Atomic.delete,Atomic.run,Atomic.images,Atomic.help,Atomic.containers,Atomic.trust,Atomic.info,Atomic.verify,Atomic.uninstall,Atomic.tag,Atomic.storage,Atomic.push,setup,Atomic.host,atomic)
      \-Export (Atomic.storage)
      \-Import (Atomic.storage)
      \-atomic (Atomic.push,Atomic.backends._docker,Atomic.update,Atomic.storage,Atomic.info,Atomic.install,Atomic.pull,Atomic.uninstall,Atomic.run,Atomic.stop,Atomic.host)
      \-backends
      | \-_containers_storage (Atomic.backendutils)
      | \-_docker (Atomic.backendutils,Atomic.run)
      | \-_docker_errors (Atomic.mount,Atomic.syscontainers,Atomic.backends._docker,Atomic.util,Atomic.atomic,Atomic.top,atomic,Atomic.client,Atomic.backendutils,Atomic.storage)
      | \-_ostree (Atomic.backendutils,Atomic.uninstall)
      | \-backend (Atomic.backends._containers_storage,Atomic.backends._ostree,Atomic.backends._docker)
      \-backendutils (Atomic.uninstall,Atomic.mount,Atomic.scan,Atomic.update,Atomic.pull,Atomic.util,Atomic.containers,Atomic.info,Atomic.install,Atomic.verify,Atomic.delete,Atomic.run,Atomic.images,Atomic.tag,Atomic.stop)
      \-client (Atomic.objects.image,Atomic.syscontainers,Atomic.diff,Atomic.backends._docker,Atomic.util,Atomic.containers,Atomic.Export,Atomic.atomic,Atomic.verify,Atomic.objects.layer)
      \-containers (atomic,atomic_dbus)
      \-delete (Atomic.images,atomic_dbus)
      \-diff (test_diff,atomic,atomic_dbus)
      \-discovery (Atomic.objects.image,Atomic.backends._docker,Atomic.util,Atomic.info,Atomic.atomic,Atomic.install,Atomic.verify,Atomic.run,Atomic.sign,test_discovery)
      \-help (Atomic.images,atomic,atomic_dbus)
      \-host (atomic)
      \-images (atomic,atomic_dbus)
      \-info (Atomic.images,atomic,atomic_dbus)
      \-install (Atomic.uninstall,atomic,atomic_dbus)
      \-mount (Atomic.scan,Atomic.images,Atomic.diff,Atomic.backends._docker,atomic_dbus,test_mount,Atomic.verify,atomic,Atomic.help)
      \-objects
      | \-container (Atomic.backends._containers_storage,Atomic.backends._ostree,Atomic.backends._docker)
      | \-image (Atomic.backends._containers_storage,Atomic.backends._ostree,Atomic.mount,Atomic.backends._docker)
      | \-layer (Atomic.backends._ostree,Atomic.objects.image,Atomic.backends._docker)
      \-pull (atomic,atomic_dbus)
      \-pulp (Atomic.push)
      \-push (atomic,atomic_dbus)
      \-rpm_host_install (Atomic.syscontainers,Atomic.backends._docker)
      \-rpmwriter (Atomic.rpm_host_install)
      \-run (atomic,atomic_dbus)
      \-satellite (Atomic.push)
      \-scan (atomic,atomic_dbus)
      \-sign (atomic,atomic_dbus)
      \-stop (atomic,atomic_dbus)
      \-storage (atomic,atomic_dbus)
      \-syscontainers (Atomic.backends._ostree,Atomic.mount,Atomic.containers,Atomic.atomic,Atomic.install,Atomic.verify)
      \-tag (Atomic.images,atomic_dbus)
      \-top (atomic,atomic_dbus)
      \-trust (Atomic.backends._containers_storage,test_trust,atomic,Atomic.backends._docker,atomic_dbus)
      \-uninstall (atomic,atomic_dbus)
      \-update (Atomic.images,atomic,atomic_dbus)
      \-util (atomic_dbus,Atomic.objects.image,Atomic.Export,Atomic.update,atomic,Atomic.sign,Atomic.backends._ostree,Atomic.mount,Atomic.scan,Atomic.diff,Atomic.backends._docker,Atomic.discovery,Atomic.storage,Atomic.pulp,Atomic.install,Atomic.rpm_host_install,Atomic.pull,Atomic.delete,Atomic.run,Atomic.objects.layer,Atomic.backendutils,atomic_dbus_client,Atomic.backends._containers_storage,Atomic.images,Atomic.help,Atomic.top,Atomic.containers,Atomic.trust,Atomic.info,Atomic.verify,Atomic.uninstall,Atomic.tag,Atomic.stop,test_discovery,Atomic.satellite,Atomic.syscontainers,test_util_sh,Atomic.push,Atomic.objects.container,test_trust,Atomic.atomic,Atomic.Import)
      \-verify (Atomic.images,atomic,atomic_dbus)
    dateutil
      \-parser (Atomic.backends._docker)
    dbus (atomic_dbus_client,atomic_dbus)
      \-mainloop
      | \-glib (atomic_dbus_client,atomic_dbus)
      \-service (atomic_dbus_client,atomic_dbus)
    docker (Atomic.mount,atomic,Atomic.client)
      \-errors (Atomic.containers,Atomic.atomic,Atomic.backends._docker,Atomic.diff)
    gi (Atomic.syscontainers)
      \-repository (Atomic.syscontainers,Atomic.mount,atomic_dbus)
    requests (Atomic.mount,Atomic.util,Atomic.trust,Atomic.atomic,Atomic.top,Atomic.pulp,Atomic.client,Atomic.storage,Atomic.satellite)
      \-exceptions (Atomic.backends._docker)
    rpm (Atomic.diff)
    selinux (Atomic.util,Atomic.storage)
    slip
      \-dbus
        \-polkit (atomic_dbus_client)
        \-service (atomic_dbus)
    urllib3 (Atomic.util)
    xattr (Atomic.mount)
    yaml (Atomic.util,test_trust,Atomic.trust)
      \-scanner (Atomic.util)



Raw metrics
-----------

+----------+-------+------+---------+-----------+
|type      |number |%     |previous |difference |
+==========+=======+======+=========+===========+
|code      |11240  |72.68 |11240    |=          |
+----------+-------+------+---------+-----------+
|docstring |1518   |9.82  |1518     |=          |
+----------+-------+------+---------+-----------+
|comment   |702    |4.54  |702      |=          |
+----------+-------+------+---------+-----------+
|empty     |2006   |12.97 |2006     |=          |
+----------+-------+------+---------+-----------+



Duplication
-----------

+-------------------------+------+---------+-----------+
|                         |now   |previous |difference |
+=========================+======+=========+===========+
|nb duplicated lines      |163   |163      |=          |
+-------------------------+------+---------+-----------+
|percent duplicated lines |1.058 |1.058    |=          |
+-------------------------+------+---------+-----------+



Messages by category
--------------------

+-----------+-------+---------+-----------+
|type       |number |previous |difference |
+===========+=======+=========+===========+
|convention |0      |0        |=          |
+-----------+-------+---------+-----------+
|refactor   |0      |0        |=          |
+-----------+-------+---------+-----------+
|warning    |0      |0        |=          |
+-----------+-------+---------+-----------+
|error      |9      |9        |=          |
+-----------+-------+---------+-----------+



% errors / warnings by module
-----------------------------

+---------------------+------+--------+---------+-----------+
|module               |error |warning |refactor |convention |
+=====================+======+========+=========+===========+
|Atomic.update        |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.uninstall     |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.syscontainers |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.stop          |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.sign          |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.objects.layer |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.objects.image |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.mount         |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+
|Atomic.host          |11.11 |0.00    |0.00     |0.00       |
+---------------------+------+--------+---------+-----------+



Messages
--------

+-----------------+------------+
|message id       |occurrences |
+=================+============+
|bad-option-value |9           |
+-----------------+------------+



Global evaluation
-----------------
Your code has been rated at 9.96/10 (previous run: 9.96/10, +0.00)

Makefile:41: recipe for target 'pylint-check' failed
make: *** [pylint-check] Error 2

[ashcrow]

@wydwww I believe this is differences in pylint versions. The actual error is E0012 which denotes when pylint gets an option that it doesn't understand. My best guess is that the pylint installed is older than the one used for developing on the atomic command.

I wasn't able to reproduce with pylint 2 1.7.4.

You can either upgrade pylint, disable bad-option-value, or remove pylint from the install pattern in the Makefile. Let me know if that works!

[wydwww]

@ashcrow Thanks for replying!
I installed newest version of pylint source, because the Debian package is 1.6 version. Now it's 1.8.0.
But still error, then I removed the pylint part from makefile.
Then I met some other problems, I'm still working, I will keep you updated.
It's getting better. Thanks!

[wydwww]

@ashcrow Finally it worked!

I updated the pylint to newest but still error, although the mark is 10/10.
Then I removed pylint part from Makefile, after installing golang, I met some permission issues and fixed.

The pylint issue is the main problem although I still don't know what goes wrong. Anyway it can build now on Debian.

Thanks

[ashcrow]

@wydwww You're welcome 🎆 😄. Do you want to put a PR in to update the Debian doc or would you rather I did it?

[wydwww]

@ashcrow I can make one in two days.

[ashcrow]

@wydwww Great! cc me on the PR when it's ready and I'll review it ASAP 😄