Atomic do not detect disk full error condition and show weird error about "'NoneType' object has no attribute 'get_label'"

[mscherer]

Same as #1144 , I tried the following command:

# atomic run openshift/origin-ansible

After downloading everything, it show this:

Need to pull openshift/origin-ansible
Pulling docker.io/openshift/origin-ansible:latest ...
Copying blob sha256:85432449fd0fabb6bef4772246d9b7948723275a4c7e4dee18728f28d79f1c2c
 65.93 MB / 70.03 MB [=====================================================>---]
Copying blob sha256:d0cf7642e3d8ee1a5bb9ed967641bf46888582f646b72ec4ce38378bd470a07b
 0 B / 1.13 KB [---------------------------------------------------------------]
Copying blob sha256:eee11c7fbb7ab2101dd113b9fa9a2080dcc845c502eb06f25ff2a2bfee3af099
 138.54 MB / 140.28 MB [=======================================================]
Copying blob sha256:879d7900e49063e3547d2a34dc20b340d683ecf6383dd625c3b83f0798915fb4
 0 B / 7.02 KB [---------------------------------------------------------------]
Copying blob sha256:6ebced23ab9dfca7fcd57e827299b8bd50bdcd2e485a5a4e45a1c1ba6bc92de2
 2.72 MB / 3.01 MB [=====================================================>-----]
Copying blob sha256:4550e37cf10e7d9446e916a298ba0ea8fc05b34054cbf230092c54bb3db845f5
 0 B / 583 B [-----------------------------------------------------------------]
Copying config sha256:15a8a3d3ec573c6ad97e2752fa93da9b27ae637056c7bb5a84c8baf704ec640d
 0 B / 7.32 KB [---------------------------------------------------------------]
Writing manifest to image destination
Storing signatures
 7.32 KB / 7.32 KB [===========================================================]'NoneType' object has no attribute 'get_label'

The traceback is the following (using a modified atomic to display it, due to #1144):

  File "/tmp/atomic", line 203, in <module>
    sys.exit(_func())
  File "/usr/lib/python3.6/site-packages/Atomic/run.py", line 123, in run
    return be.run(img_object, atomic=self, args=self.args)
  File "/usr/lib/python3.6/site-packages/Atomic/backends/_docker.py", line 584, in run
    if iobject.get_label('INSTALL') and not args.ignore and not util.InstallData.image_installed(iobject):
AttributeError: 'NoneType' object has no attribute 'get_label'

[mscherer]

I decided to try with another docker image, like busybox, and it work. It doesn't download it several time, and it run it without trouble on first try.

So there is something weird with the openshift/origin-ansible image that trigger the bug, but I can't see what.

[mscherer]

Ok so the problem is that atomic fail to pull the image (not enough disk space), but fail to report the issue. Once I used docker pull, all was fine.

I have added disk and will see if #1145 is also suffering from the same root cause.