Refactor nulecule base [Fixes #145] #278

rtnpro · 2015-09-18T08:22:30Z

This includes initial work on refactoring Nulecule base code, as discussed in #145 .

goern · 2015-09-18T08:49:57Z

atomicapp/nulecule/__init__.py

just this morning a little picky... "an Application compliant with the Nulecule Specification" ;)

vpavlin · 2015-09-18T18:14:47Z

Hmm..you are quick, guys:) I put this together yesterday: https://gist.github.com/vpavlin/f46444efd647e0d8a48f

Maybe I missed some discussion, so if that's the case, can we reiterate on it? Or if that didn't happen, can I have one, please?:)

vpavlin · 2015-09-21T10:17:00Z

atomicapp/nulecule/__init__.py

What about moving this to load(), or moving load_components() out of load ?

aweiteka · 2015-09-22T14:54:18Z

I haven't done a full code review but I agree this is in the right direction. It will help with my work in progress #142 .

@vpavlin do you consider this foundational to address your gist?

vpavlin · 2015-09-23T06:20:45Z

@aweiteka Yes, I think this is going into the right direction:)

landscape-bot · 2015-09-23T19:01:10Z

Repository health decreased by 1% when pulling 591ac68 on rtnpro:refactor_nulecule_base into cb931ec on projectatomic:master.

7 new problems were found (including 0 errors and 5 code smells).
No problems were fixed.

cdrage · 2015-09-23T22:02:23Z

👍 on the docker-py, if we decide to use that we can interact with the docker commands more programatically.

although this does add another dependancy...

@goern thoughts?

landscape-bot · 2015-09-27T01:55:29Z

Repository health decreased by 2% when pulling ef755c0 on rtnpro:refactor_nulecule_base into cb931ec on projectatomic:master.

7 new problems were found (including 1 error and 4 code smells).
No problems were fixed.

landscape-bot · 2015-10-06T20:12:27Z

Repository health decreased by 5% when pulling fa2aa73 on rtnpro:refactor_nulecule_base into 80d17bf on projectatomic:master.

18 new problems were found (including 4 errors and 12 code smells).
1 problem was fixed (including 0 errors and 1 code smell).

aweiteka · 2015-10-07T12:19:24Z

@rtnpro nice work! LGTM

cdrage · 2015-10-07T12:50:16Z

@rtnpro

Few questions,

Is there any possibility to add some testing?
Is it bad naming practice to have both a NuleculeBase and Nulecule_Base? As that's what we currently have

cdrage · 2015-10-07T12:51:11Z

atomicapp/nulecule/__init__.py

What is /var/atomicapp doesn't exist? fails?

cdrage · 2015-10-07T12:55:31Z

@rtnpro can you rebase too so I can git clone your branch and test it :)

rtnpro · 2015-10-07T13:23:06Z

@charliedrage I just rebased the branch :)

rtnpro · 2015-10-07T13:48:55Z

On Wed, Oct 7, 2015 at 6:20 PM, Charlie Drage notifications@github.com wrote:

@rtnpro

Few questions,

Is there any possibility to add some testing?

Yes, of course, and I will start to work on it, to wire up this new
package and cover all edge cases.

Is it bad naming practice to have both a NuleculeBase and Nulecule_Base? As that's what we currently have

It is, indeed. Python suggests use of CapWords for class names and
_ (underscore) separated names for variable and function names for
better readability. You can read more about it here:
https://www.python.org/dev/peps/pep-0008/#function-names. However, in
our current code, we have a mix of various styles. I'm more inclined
to stick to the PEP8 guidelines, and it reflects in the newer code of
nulecule package. In time, we'll refactor the entire code base to
follow a consistent naming convention. Does it make sense?

rtnpro · 2015-10-07T13:49:13Z

@charliedrage ^^

landscape-bot · 2015-10-09T03:25:12Z

Repository health decreased by 4% when pulling dd0e7be on rtnpro:refactor_nulecule_base into 5d81806 on projectatomic:master.

18 new problems were found (including 4 errors and 12 code smells).
No problems were fixed.

LalatenduMohanty · 2015-10-09T08:35:10Z

@rtnpro Code is more readable now :)

vpavlin · 2015-10-09T12:25:36Z

atomicapp/constants.py

Make it /var/lib/atomicapp, please:)

Running a Nulecule application now generates a file named "answers.conf.gen" in the application directory, which contains all config data (answers + user input) used to run the application. The same data is loaded and used to stop the application without asking the user for any input.

- use 'in' to find a char in string rather than str.find - strip of 'docker://' prefix in source image name using Utils.getSourceImage - Update CACHE_DIR to '/var/lib/atomicapp'

- added docs - added logs - fixed dry-run, nodeps argument handling

- Fix generating paths for rendered artifacts, to feed to provider - Prevent deploying external application multipled times.

…ile.

If at all it is needed to copy a Nulecule application directory to another path, when --destination option is provided in atomicapp install command, then the caller will copy the application directory to the destination first, and then call Nulecule.load_from_path to load the Nulecule application from the destination path.

and fix 'ask' option for load_config as well. This commit allows us to load_config parameters for the entire nulecule application during install and dumping it to answers.conf.sample without prompting the user for any input.

rtnpro · 2015-10-15T13:17:57Z

Rebased!

dustymabe · 2015-10-15T13:36:56Z

Ok this has been incorporated in https://github.com/projectatomic/atomicapp/commits/cdk2-beta3-rc1 I'm going to lock comments here.. new things can go into issues/PRs to https://github.com/projectatomic/atomicapp/commits/cdk2-beta3-rc1.

goern reviewed Sep 18, 2015
View reviewed changes

goern added this to the CDK 2 beta-3 milestone Sep 18, 2015

cdrage mentioned this pull request Sep 18, 2015

Handling OpenShift templates #222

Open

vpavlin reviewed Sep 21, 2015
View reviewed changes

atomicapp/nulecule/__init__.py Outdated

Copy link

Contributor

vpavlin Sep 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about moving this to load(), or moving load_components() out of load ?

cdrage reviewed Oct 7, 2015
View reviewed changes

atomicapp/nulecule/__init__.py Outdated

Copy link

Member

cdrage Oct 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is /var/atomicapp doesn't exist? fails?

rtnpro force-pushed the refactor_nulecule_base branch from fa2aa73 to 783940c Compare October 7, 2015 13:19

cdrage assigned rtnpro Oct 7, 2015

cdrage added the work in progress label Oct 7, 2015

rtnpro force-pushed the refactor_nulecule_base branch from 783940c to dd0e7be Compare October 8, 2015 12:49

vpavlin reviewed Oct 9, 2015
View reviewed changes

rtnpro added 21 commits October 15, 2015 18:46

Integrate atomicapp run command with NuleculeManager.

49c2417

Integrated atomicapp stop command with NuleculeManager.

f733026

Added scaffolding for unittests for NuleculeManager.

24678f9

Added missing nulecule/exceptions.py file.

9588d35

Moved initializing instance variables used by NuleculeBase to itself.

e0ea9bc

Miscellaneous fixes based on code review

f66970d

- use 'in' to find a char in string rather than str.find - strip of 'docker://' prefix in source image name using Utils.getSourceImage - Update CACHE_DIR to '/var/lib/atomicapp'

Streamlined install flow

f147596

- added docs - added logs - fixed dry-run, nodeps argument handling

Fix run flow

2d646b9

- Fix generating paths for rendered artifacts, to feed to provider - Prevent deploying external application multipled times.

Write collected config data to answers.conf.sample during install.

9462c3f

Fix loading config data during run.

3c97642

Ensure provider and namespace info are present in generated answers f…

586cda8

…ile.

NuleculeManager can now run application directly from an image.

e9c0a50

Removed unused imports in nulecule/main.py.

be535b0

Move definitions of Nulecule and NuleculeComponent to nulecule/base.py

f6201d1

Remove deprecated atomicap/{install,run,nulecule_base}.py files.

404af83

Repalace dangling shutil with distutils.

fc5e557

Enable skip_asking option during loading config

70303d2

and fix 'ask' option for load_config as well. This commit allows us to load_config parameters for the entire nulecule application during install and dumping it to answers.conf.sample without prompting the user for any input.

Fixed imports for distutils.dir_util

788a9dd

Don't try to stop a NuleculeComponent multiple times.

54bf04c

rtnpro force-pushed the refactor_nulecule_base branch from 2501bad to 54bf04c Compare October 15, 2015 13:17

projectatomic locked and limited conversation to collaborators Oct 15, 2015

goern added the blocked label Oct 15, 2015

cdrage added cdk2-beta3-rc1 and removed work in progress labels Oct 19, 2015

cdrage removed the blocked label Oct 29, 2015

dustymabe merged commit 54bf04c into projectatomic:master Nov 3, 2015

Refactor nulecule base [Fixes #145] #278

Refactor nulecule base [Fixes #145] #278

Uh oh!

Conversation

rtnpro commented Sep 18, 2015

Uh oh!

goern Sep 18, 2015

Choose a reason for hiding this comment

Uh oh!

vpavlin commented Sep 18, 2015

Uh oh!

vpavlin Sep 21, 2015

Choose a reason for hiding this comment

Uh oh!

aweiteka commented Sep 22, 2015

Uh oh!

vpavlin commented Sep 23, 2015

Uh oh!

landscape-bot commented Sep 23, 2015

Uh oh!

cdrage commented Sep 23, 2015

Uh oh!

landscape-bot commented Sep 27, 2015

Uh oh!

landscape-bot commented Oct 6, 2015

Uh oh!

aweiteka commented Oct 7, 2015

Uh oh!

cdrage commented Oct 7, 2015

Uh oh!

cdrage Oct 7, 2015

Choose a reason for hiding this comment

Uh oh!

cdrage commented Oct 7, 2015

Uh oh!

rtnpro commented Oct 7, 2015

Uh oh!

rtnpro commented Oct 7, 2015

Uh oh!

rtnpro commented Oct 7, 2015

Uh oh!

landscape-bot commented Oct 9, 2015

Uh oh!

LalatenduMohanty commented Oct 9, 2015

Uh oh!

vpavlin Oct 9, 2015

Choose a reason for hiding this comment

Uh oh!

rtnpro Oct 13, 2015

Choose a reason for hiding this comment

Uh oh!

rtnpro commented Oct 15, 2015

Uh oh!

dustymabe commented Oct 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants