Skip to content
This repository was archived by the owner on Jan 19, 2018. It is now read-only.

Conversation

@cdrage
Copy link
Member

@cdrage cdrage commented Jan 26, 2016

No description provided.

@dustymabe
Copy link
Contributor

Should we also try to go through the code and update any references in the comments to "install" ?

@cdrage
Copy link
Member Author

cdrage commented Jan 26, 2016

@dustymabe yup, that's what I did! I am updating the README.md in a separate PR.

@dustymabe
Copy link
Contributor

@cdrage, what PR are you referring to?

Also here are some more findings:

$ grep -Ri install ./atomicapp/
./atomicapp/cli/main.py:                "This will install and run an Atomic App, "
./atomicapp/cli/main.py:                Destination directory for install. This defaults to a
./atomicapp/cli/main.py:                Path to the directory where the Atomic App is installed
./atomicapp/providers/kubernetes.py:        Actions are either: run, stop or uninstall as per the Requirements class
./atomicapp/nulecule/base.py:            A Nulecule instance or None in case of some dry run (installing
./atomicapp/nulecule/base.py:            raise NuleculeException("Installed Nulecule components are required to initiate dry-run. "
./atomicapp/nulecule/lib.py:    def uninstall(self):
./atomicapp/nulecule/main.py:    Interface to install, run, stop a Nulecule application.
./atomicapp/nulecule/main.py:        Installs (unpacks) a Nulecule application from a Nulecule image
./atomicapp/nulecule/main.py:            nodeps (bool): Install the nulecule application without installing
./atomicapp/nulecule/main.py:            update (bool): Pull requisite Nulecule image and install or
./atomicapp/nulecule/main.py:                           update already installed Nulecule application

@cdrage cdrage force-pushed the install-to-fetch-in-docs branch from f1eb867 to c47cb70 Compare February 12, 2016 18:32
@cdrage
Copy link
Member Author

cdrage commented Feb 12, 2016

@dustymabe
updated!

Updating README is pull #535

@dustymabe
Copy link
Contributor

LGTM. Assuming tests pass go ahead and merge.

cdrage added a commit that referenced this pull request Feb 12, 2016
Remove instances of install verb to fetch
@cdrage cdrage merged commit 479e30e into projectatomic:master Feb 12, 2016
@cdrage cdrage deleted the install-to-fetch-in-docs branch February 12, 2016 19:45
@cdrage
Copy link
Member Author

cdrage commented Feb 12, 2016

They did 👍 merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants