This repository was archived by the owner on Jan 19, 2018. It is now read-only.
Fail if unable to find artifact #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| artifact_paths.append(dir_child_path) | ||
| else: | ||
| raise NuleculeException("Unable to find artifact %s" % path) | ||
|
|
Contributor
There was a problem hiding this comment.
so right now we only raise an exception if the file or dir doesn't exist. what happens if they pass us a directory but the directory is empty? Should that be an error?
cdrage
force-pushed
the
fail-if-file-not-found
branch
from
d587307 to
c058de0
Compare
Member
Author
|
PR updated to include if directory is empty. |
atomicapp/nulecule/base.py
Outdated
| continue | ||
| artifact_paths.append(dir_child_path) | ||
| elif os.listdir(path) == []: | ||
| raise NuleculeException("Artifact directory %s is empty" % path) |
Contributor
There was a problem hiding this comment.
this is dead code. If it is a directory the it will pass the 2nd if and won't ever get to the 3rd one right?
cdrage
force-pushed
the
fail-if-file-not-found
branch
from
c058de0 to
8df8b1c
Compare
Member
Author
|
Hey @dustymabe I updated it, don't know if it's to your satisfaction, hopefully it's better 👍 |
cdrage
force-pushed
the
fail-if-file-not-found
branch
from
8df8b1c to
5f621d5
Compare
Contributor
|
LGTM. rebase and merge please |
Contributor
|
@cdrage ^^ |
cdrage
force-pushed
the
fail-if-file-not-found
branch
from
5f621d5 to
0b9b580
Compare
Member
Author
|
Rebased and unit/integration tests pass. Mergin' |
cdrage
added a commit
that referenced
this pull request
Feb 22, 2016
Fail if unable to find artifact
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd half of #532, raises NuleculeException if unable to find a file.
Another PR ahead for failing when using a wrong inherited provider, (ex. providing inherit: foobar).