This repository was archived by the owner on Jan 19, 2018. It is now read-only.
OpenShift to KubeShift #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
force-pushed
the
openshift-to-kubeshift
branch
9 times, most recently
from
e9ab1f7 to
aae0e4e
Compare
cdrage
force-pushed
the
openshift-to-kubeshift
branch
6 times, most recently
from
8ff0186 to
0374d41
Compare
cdrage
force-pushed
the
openshift-to-kubeshift
branch
14 times, most recently
from
8573d26 to
f0ff91c
Compare
|
|
||
| # Check the API url | ||
| url = self.api.cluster['server'] | ||
| print url |
cdrage
force-pushed
the
openshift-to-kubeshift
branch
from
f2fefb2 to
bc69420
Compare
| from urllib import urlencode | ||
| from atomicapp.providers.lib.kubeshift.kubebase import KubeBase | ||
| from atomicapp.providers.lib.kubeshift.exceptions import KubeOpenshiftError | ||
| from atomicapp.constants import LOGGER_DEFAULT |
Contributor
There was a problem hiding this comment.
move LOGGER_DEFAULT to above import KubeBase so that it matches kubernetes.py
cdrage
force-pushed
the
openshift-to-kubeshift
branch
3 times, most recently
from
fd38c0d to
098db0b
Compare
Contributor
|
can we have a better commit message than "refactor" ? |
Member
Author
|
@dustymabe Yeah, I was going to update this after the code changes :) |
cdrage
force-pushed
the
openshift-to-kubeshift
branch
5 times, most recently
from
8af1aaf to
543fef0
Compare
Member
Author
|
Updated the PR with the OpenShift namespaces fix as per openshift/origin#10334 |
atomicapp/providers/openshift.py
Outdated
|
|
||
| # Check if the namespace that the app is being deployed to is available | ||
| # DISABLED at the moment due to issues with OpenShift 1.3.0 | ||
| # https://github.com/openshift/origin/issues/10334 |
Contributor
There was a problem hiding this comment.
remove the two lines of comments above
This commit converts the current OpenShift provider to use the 'KubeShift' library. Allowing OpenShift to use the universal library for both Kubernetes and OpenShift, decreasing technical debt in learning how each provider API communicates. Tests are also added which cover a large majority of test scenarios for the KubeShift library. Included is a new pytest plugin which allows mocking an example HTTP server.
cdrage
force-pushed
the
openshift-to-kubeshift
branch
from
543fef0 to
1a37ab8
Compare
Member
Author
|
#dotests |
Contributor
|
I think we are good to go.. merge away |
Contributor
|
maybe remove WIP from title first |
Member
Author
|
@dustymabe just going to run through a few last-minute tests and we'll be good to go :) |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An open PR to keep track of progress
TODO:
openshift.pytests