Skip to content
This repository was archived by the owner on Jan 19, 2018. It is now read-only.

Conversation

@rtnpro
Copy link
Contributor

@rtnpro rtnpro commented Jan 25, 2016

Adds support for global params in Nulecule spec to support projectatomic/atomicapp#378

@aweiteka
Copy link
Contributor

It's significant to add another top-level element but I understand the rationale. Referencing the existing params object is nice and clean.

For background discussion see projectatomic/atomicapp#378, specifically projectatomic/atomicapp#378 (comment)

LGTM

@cdrage
Copy link
Member

cdrage commented Mar 14, 2016

I agree with @rtnpro the rational for global params brings a much cleaner slate to Nulecule.

We can have both. Having global params certainly helps bring minimalism to the table.

This LGTM. Let's get this in! 👍

@goern
Copy link
Contributor

goern commented Mar 14, 2016

I'm offline today and will revisited it tomorrow

Principal Software Engineer - Systems Design & Engineering
Mobile: +49 171 2801345

Red Hat GmbH, http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Paul Argiry, Charles Cachera, Michael Cunningham, Michael
O'Neill

@dustymabe
Copy link
Contributor

LGTM, let's get this in unless we get feedback from christoph that points otherwise.

goern added a commit that referenced this pull request Mar 17, 2016
Allow global params in Nulecule spec.
@goern goern merged commit c22c699 into projectatomic:master Mar 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants