BACKPORT: kill.go: Remove unnecessary checks#18
Merged
runcom merged 1 commit intoprojectatomic:docker-1.13.1-rhelfrom Dec 11, 2018
Merged
BACKPORT: kill.go: Remove unnecessary checks#18runcom merged 1 commit intoprojectatomic:docker-1.13.1-rhelfrom
runcom merged 1 commit intoprojectatomic:docker-1.13.1-rhelfrom
Conversation
upstream commit: opencontainers/runc@7ac503d ... that prevent sending signals not mentioned in signal map. Currently these are SIGRTMIN..SIGRTMAX. Signed-off-by: Valentin Kulesh <valentin.kulesh@virtuozzo.com> Signed-off-by: Wang Long <wanglong19@meituan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, maintainers.
Graceful shutdown and kill with SIGRTMIN..SIGRTMAX don't work when we run systemd in docker container.
This upstream patch fix it, so I want to backport it rhel's docker repo.(Fixes: #16)
For more info:
SIGRTMIN..SIGRTMAXdon't work moby/moby#36219upstream commit: opencontainers/runc@7ac503d
... that prevent sending signals not mentioned in signal map.
Currently these are SIGRTMIN..SIGRTMAX.
Signed-off-by: Valentin Kulesh valentin.kulesh@virtuozzo.com
Signed-off-by: Wang Long wanglong19@meituan.com