[4.5] cgroup, systemd: cleanup cgroups#34
Merged
Conversation
some hierarchies were created directly by .Apply() on top of systemd managed cgroups. systemd doesn't manage these and as a result we leak these cgroups. Cherry-picked-by: Peter Hunt <pehunt@redhat.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Collaborator
Author
Collaborator
Author
|
ptal @mrunalp @kolyshkin |
RemovePaths() deletes elements from the paths map for paths that has been successfully removed. Although, it does not empty the map itself (which is needed that AFAIK Go garbage collector does not shrink the map), but all its callers do. Move this operation from callers to RemovePaths. No functional change, except the old map should be garbage collected now. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
Author
|
also added opencontainers/runc@254d23b |
Collaborator
|
Looks fine. I will wait for @kolyshkin to do final review and merge. |
Collaborator
|
This is a backport of opencontainers/runc#2503, fixing a regression introduced by commit bfa1b2a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some hierarchies were created directly by .Apply() on top of systemd
managed cgroups. systemd doesn't manage these and as a result we leak
these cgroups.
Cherry-picked-by: Peter Hunt pehunt@redhat.com
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com
[This is a backport of opencontainers/runc#2503, fixing a regression introduced by commit bfa1b2a]