Skip to content

fix(gschema): xdg-terminal-exec for terminal keyboard shortcuts#265

Open
hanthor wants to merge 1 commit intoprojectbluefin:mainfrom
hanthor:use-xdg-terminal-exec-for-keybindings
Open

fix(gschema): xdg-terminal-exec for terminal keyboard shortcuts#265
hanthor wants to merge 1 commit intoprojectbluefin:mainfrom
hanthor:use-xdg-terminal-exec-for-keybindings

Conversation

@hanthor
Copy link
Copy Markdown
Member

@hanthor hanthor commented Apr 8, 2026

Summary

  • Replace hardcoded /usr/bin/ptyxis --new-window with xdg-terminal-exec for the ctrl+alt+t and ctrl+alt+return shortcuts
  • xdg-terminal-exec is the freedesktop standard for opening the user's configured default terminal, respecting ~/.config/xdg-terminals.list
  • Already used in Bluefin for the logo menu button (menu-button-terminal='xdg-terminal-exec' in 04-bluefin-logomenu-extension)

Motivation: On Bluefin, this is a no-op — xdg-terminal-exec defaults to Ptyxis. But on downstream variants like Dakota that ship Ghostty as the default terminal, the shortcuts currently open Ptyxis instead of Ghostty, which is inconsistent with the logo menu button behavior.

Test plan

  • On Bluefin: ctrl+alt+t still opens Ptyxis
  • On Dakota: ctrl+alt+t opens Ghostty
  • Logo menu terminal button and keyboard shortcuts now use the same mechanism

🤖 Generated with Claude Code

Replace hardcoded /usr/bin/ptyxis --new-window with xdg-terminal-exec
for ctrl+alt+t and ctrl+alt+return. This respects the user's configured
default terminal (via xdg-terminals.list) rather than always opening
Ptyxis — consistent with how the logo menu button already works.

On Bluefin, xdg-terminal-exec defaults to Ptyxis. On Dakota (which
ships Ghostty), it opens Ghostty instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area/gnome Anything GNOME related kind/enhancement New feature, don't implement without a spec and consensus labels Apr 8, 2026
@hanthor hanthor changed the title Use xdg-terminal-exec for terminal keyboard shortcuts fix(gschema): xdg-terminal-exec for terminal keyboard shortcuts Apr 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the custom keybindings configuration to use xdg-terminal-exec instead of the hardcoded Ptyxis terminal path, improving terminal compatibility. I have no further feedback to provide.

@hanthor hanthor enabled auto-merge April 9, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gnome Anything GNOME related kind/enhancement New feature, don't implement without a spec and consensus size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant