Restore clickability for all tiles with 1 concept. #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all tiles had their clicking disabled by faulty logic. Pebble doesn't know how to handle the `.length` property of arrays, and interpreted it as null, which prevented the relevant code from firing. This change converts `ChartItem#conceptUuids` to a List instead of an array, such that Pebble is capable of working with the field.
capnfabs
added a commit
that referenced
this pull request
Feb 9, 2016
Restore clickability for all tiles with 1 concept.
Contributor
|
Let's ditch peeble please!!! 😄 |
Contributor
|
great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all tiles had their clicking disabled by faulty logic. Pebble doesn't know how to handle
the
.lengthproperty of arrays, and interpreted it as null, which prevented the relevant codefrom firing. This change converts
ChartItem#conceptUuidsto a List instead of an array, such thatPebble is capable of working with the field.