Skip to content
This repository was archived by the owner on Oct 20, 2025. It is now read-only.

Enable ipv6 in the dind test container.#163

Merged
caseydavenport merged 1 commit intoprojectcalico:masterfrom
djlwilder:ipv6-test
Nov 17, 2017
Merged

Enable ipv6 in the dind test container.#163
caseydavenport merged 1 commit intoprojectcalico:masterfrom
djlwilder:ipv6-test

Conversation

@djlwilder
Copy link
Copy Markdown
Contributor

@djlwilder djlwilder commented Nov 16, 2017

Fix for issue #162.

Signed-off-by: David Wilder wilder@us.ibm.com

Description

This patch avoids a Ci failure we have been seeing on Semaphore for some time. See issue #162

Here is the failure.

$ make test-containerized
<cut>
  • Failure [3.068 seconds]
Libnetwork Tests
/go/src/github.com/projectcalico/libnetwork-plugin/tests/default_environment/libnetwork_test.go:345
  docker run ipv6
  /go/src/github.com/projectcalico/libnetwork-plugin/tests/default_environment/libnetwork_test.go:342
    creates a container on a network  and checks all assertions [It]
    /go/src/github.com/projectcalico/libnetwork-plugin/tests/default_environment/libnetwork_test.go:341

    Expected
        <string>: 2001:db8:7f30:3859:b73a:3e8b:9882:1bc0 dev cali0  metric 256 
        fe80::/64 dev cali0  metric 256 
        unreachable default dev lo  metric -1  error -101
        ff00::/8 dev cali0  metric 256 
        unreachable default dev lo  metric -1  error -101
    to match regular expression
        <string>: default via fe80::.* dev cali0  metric 1024

This is a change to test code only. My concern is if this is truly a test failure or a limitation of Calico. See my comments in issue #162. This patch re-enables ipv6 inside the dind container.

I am ok calling this a test bug to get Ci working again.

Fix for issue projectcalico#162.

Signed-off-by: David Wilder <wilder@us.ibm.com>
Copy link
Copy Markdown
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djlwilder thanks for the investigation and fix for this one.

I think I'm comfortable calling this a CI bug - our tests expect ipv6 addresses but don't enable ipv6 on the "host".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants