fix(calc-questions): always calculate calculated answer if possible#2874
Draft
winged wants to merge 2 commits into
Draft
fix(calc-questions): always calculate calculated answer if possible#2874winged wants to merge 2 commits into
winged wants to merge 2 commits into
Conversation
We don't need to ensure that *every* dependency is non-hidden; indeed it should be possible to evaluate an expression where parts of the dependencies are not set. This is how the backend does it. Also, the `answer` transform does have a default option, so we should easily be able to deal with this.
The answer transform should behave exactly as follows: * Field does not exist: return default value, or empty * Field is hidden: Return empty value * Field is unset: Return default value or empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to ensure that every dependency is non-hidden; indeed it should be possible to evaluate an expression where parts of the dependencies are not set. This is how the backend does it. Also, the
answertransform does have a default option, so we should easily be able to deal with this.