Skip to content

fix: respect -pr http11 flag by disabling HTTP/2 fallback #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VoidChecksum wants to merge 1 commit into
base: dev
Choose a base branch
from
+13 −2
Open

fix: respect -pr http11 flag by disabling HTTP/2 fallback #2450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions common/httpx/httpx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,22 @@ func New(options *Options) (*HTTPX, error) {
transport.Proxy = http.ProxyURL(proxyURL)
}

httpx.client = retryablehttp.NewWithHTTPClient(&http.Client{
httpClient := &http.Client{
Transport: transport,
Timeout: httpx.Options.Timeout,
CheckRedirect: redirectFunc,
}, retryablehttpOptions)
}
httpx.client = retryablehttp.NewWithHTTPClient(httpClient, retryablehttpOptions)

// When HTTP/1.1-only mode is requested, the retryablehttp-go library still
// has an internal fallback (HTTPClient2) that retries with a native HTTP/2
// client when it encounters certain error messages about malformed HTTP/2
// responses. Override that fallback client with the same HTTP/1.1 transport
// so the -pr http11 flag is respected throughout the entire request
// lifecycle, including retries.
if httpx.Options.Protocol == "http11" {
httpx.client.HTTPClient2 = httpClient
}
Comment on lines +180 to +195

transport2 := &http2.Transport{
TLSClientConfig: &tls.Config{
Expand Down
Loading