Skip to content

skip setting "available: false" in "node down"#81

Merged
jschwinger233 merged 1 commit intoprojecteru2:masterfrom
DuodenumL:feature/bypass
Dec 22, 2021
Merged

skip setting "available: false" in "node down"#81
jschwinger233 merged 1 commit intoprojecteru2:masterfrom
DuodenumL:feature/bypass

Conversation

@DuodenumL
Copy link
Copy Markdown
Contributor

按照最新的会议精神,node down这个命令只应该设置bypass,而不应设置available的值。否则会产生比较恶心的后果:

  1. cli设置了available: false,
  2. core会删除node status,
  3. selfmon会调用set node down,
  4. node上所有的workload都会被设置为running: false。

@jschwinger233
Copy link
Copy Markdown
Member

selfmon 和 available/bypass 双状态的 bug 太多了, 接下来就来梳理一下.

@jschwinger233 jschwinger233 merged commit 47992bf into projecteru2:master Dec 22, 2021
@DuodenumL
Copy link
Copy Markdown
Contributor Author

求打个tag,方便qa那边用

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants