set node's endpoint & tls configs#83
Merged
jschwinger233 merged 1 commit intoprojecteru2:masterfrom Dec 31, 2021
Merged
Conversation
Collaborator
|
你这 go.mod不太行 |
Contributor
Author
所以是WIP...要core那边合了，这边才能改成正确的go mod |
|
|
||
| nodename := c.String("nodename") | ||
| if nodename == "" { | ||
| n, err := os.Hostname() |
Member
There was a problem hiding this comment.
这些默认值都可以放到 cli 声明命令行参数那里吧, 包括上面的 83(旧)/69(新)行
Contributor
Author
There was a problem hiding this comment.
nodename这个可以，但是L69那个不太行，假设/etc/docker/tls/ca.crt不存在，L75（新）应该会报错
DuodenumL
force-pushed
the
feature/endpoint
branch
from
4a05327 to
2c04e93
Compare
Member
|
更新一下 go.mod, 准备合并 |
DuodenumL
force-pushed
the
feature/endpoint
branch
from
2c04e93 to
6b609e2
Compare
DuodenumL
changed the title
Contributor
Author
好了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node set现在支持设置endpoint / ca / cert / key了。
之前有个node update的命令可以设置endpoint，功能重复，我就给删了...不过为了兼容，把node set设置了个alias，现在node update完全等价于node set。