ongoingFactEntry: Remove custom style class #379
Conversation
This fixes the "Enter activity.." text input to actually be usable and visible on my Ubuntu 24.04 (GNOME 46) when using light mode. In dark mode having the extra style class seems to work fine, but in light mode the input field is a light color and the text is also almost in the same color, so you cannot see what you write.
| track_hover: true, | ||
| hint_text: _("Enter activity…"), | ||
| style_class: "search-entry" | ||
| hint_text: _("Enter activity…") |
There was a problem hiding this comment.
I have no idea if this is the right way to fix it, but opening a PR just to start the discussion. The custom style was added in e7b2e5c.
There was a problem hiding this comment.
I don't see this issue. It might be related to your gtk theme settings.
The commit that introduced it is ancient.
There was a problem hiding this comment.
Thanks for the hint! I was thinking I have a fairly standard Ubuntu 24.04 with GNOME.. But I installed a clean Ubuntu 24.04 in a VM and was unable to reproduce the same problem.
After searching through my home directory I found a reference to search-entry in the Blur my Shell extension. And indeed, after installing Blur my Shell in the VM I immediately got the same problem.
So maybe I should report the issue there instead?
There was a problem hiding this comment.
Looking back at #103 it seems like it was a workaround added for old GNOME versions 🤔 Or? So is it needed for anything any more?
There was a problem hiding this comment.
Honestly, I don't know. I'm not sure if current GNOME versions still use style_class at all (but I'm assuming it does, otherwise removing wouldn't have an effect, right?).
In general I would say it is innocent. We're not mandating anything about background or font colors or any other specific style attributes. It's just an abstract hint about the purpose of the widget. AFAICT this is how it should be done. It's then up the theme to determine how `search-entry´ widgets should be rendered.
I haven't heard about "blur my shell" so far. I'm generally sceptical about extensions that only add eye candy. As the authors of that extension seem to care a lot about this kind of things, maybe they'll be able to fix it, or at least provide some insight about style_class and how they handle it.
There was a problem hiding this comment.
I am a bit confused why an extension like "blur my shell" is necessary at all. To my understanding, this is what themes are for. Possibly the extension is doing stuff that can't be done with themes. But then, effects like the one you describe should be expected. The extension would need to take utmost care to play well with the settings the current theme is applying, which (I suppose) will be hard.
2 participants
This fixes the "Enter activity.." text input to actually be usable and visible on my Ubuntu 24.04 (GNOME 46) when using light mode.
In dark mode having the extra style class seems to work fine, but in light mode the input field is a light color and the text is also almost in the same color, so you cannot see what you write.
With the fix:
Without the fix: