(feat) Pause profiles #1359
Merged
(feat) Pause profiles #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When profile has annotation `profile.projectsveltos.io/paused` Sveltos considers it paused and no reconciliation happens. This means: - set of matching clusters is not updated - clusterSummary instances are not updated This PR implements code change, unit test and function test. This PR also rewrites the comment on the field `dependsOn` clarifying ClusterProfile can only depend on other ClusterProfile instances and that Profile can only depend on other Profile instances.
gianlucam76
force-pushed
the
pause-profile
branch
from
27701b3 to
1046692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profile has annotation
profile.projectsveltos.io/pausedSveltos considers it paused and no reconciliation happens. This means:This PR implements code change, unit test and function test.
This PR also rewrites the comment on the field
dependsOnclarifying ClusterProfile can only depend on other ClusterProfile instances and that Profile can only depend on other Profile instances.Fixes #1358