(feat) Generated ClusterProfile name #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request (PR) changes how the event manager names ClusterProfile instances.
Previously, the names were random, which made it impossible to predict what a new
ClusterProfile would be named. This unpredictability became an issue in situations
where we needed to know the name beforehand to set other ClusterProfile instances
as dependent on it.
This PR introduces an optional field in the EventTrigger spec called **InstantiatedProfileNameFormat**.
This field allows to define a naming template for the generated ClusterProfile.
For example, using the template
`{{ .Cluster.metadata.name }}-{{ .Resource.metadata.name }}-test`
Sveltos will automatically generate a name for the ClusterProfile instance based on the
cluster and event data when an event occurs.
This provides a predictable naming convention that can used for dependency management.
This PR contains code changes, unit test and functional test
gianlucam76
force-pushed
the
profile-name
branch
from
5297fe1 to
8b07565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (PR) changes how the event manager names ClusterProfile instances. Previously, the names were random, which made it impossible to predict what a new ClusterProfile would be named. This unpredictability became an issue in situations where we needed to know the name beforehand to set other ClusterProfile instances as dependent on it.
This PR introduces an optional field in the EventTrigger spec called InstantiatedProfileNameFormat. This field allows to define a naming template for the generated ClusterProfile.
For example, using the template
{{ .Cluster.metadata.name }}-{{ .Resource.metadata.name }}-testSveltos will automatically generate a name for the ClusterProfile instance based on the cluster and event data when an event occurs.
This provides a predictable naming convention that can used for dependency management.
This PR contains code changes, unit test and functional test
Fixes #377