EventReport: mark matchingResources with listType=atomic #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A EventSource starts a watcher on specified resources. Any resource change triggers the EventSource to be reprocessed, which discovers all matching resources and updates the EventReport. When collectResources is set to false, an EventSource might be processed multiple times even if the list of matching resources hasn't changed. Any EventReport update causes event-manager to reprocess it on the control cluster. To prevent redundant updates to the EventReport the update can be skipped entirely, provided the matching resources are sorted and maintained in a sorted state within the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A EventSource starts a watcher on specified resources. Any resource change triggers the EventSource to be reprocessed, which discovers all matching resources and updates the EventReport.
When collectResources is set to false, an EventSource might be processed multiple times even if the list of matching resources hasn't changed. Any EventReport update causes event-manager to reprocess it on the control cluster.
To prevent redundant updates to the EventReport the update can be skipped entirely, provided the matching resources are sorted and maintained in a sorted state within the report.