fix(search): empty matchers early return ignored result #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
MichaHoffmann
force-pushed
the
mhoffmann/fix-empty-matcher
branch
from
fd9e618 to
fd799c2
Compare
Collaborator
Author
|
We dont coalesce pages on regex matchers yet so there was nothing to fix there, but we should do the same on regex eventually. |
3 tasks
francoposa
pushed a commit
that referenced
this pull request
Jul 25, 2025
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com> Signed-off-by: francoposa <franco@francoposa.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.