Make Stackdriver main collector more library-friendly#157
Merged
SuperQ merged 12 commits intoprometheus-community:masterfrom May 19, 2022
Merged
Make Stackdriver main collector more library-friendly#157SuperQ merged 12 commits intoprometheus-community:masterfrom
SuperQ merged 12 commits intoprometheus-community:masterfrom
Conversation
Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Co-authored-by: kgeckhart <kgeckhart@users.noreply.github.com> Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Co-authored-by: kgeckhart <kgeckhart@users.noreply.github.com> Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Co-authored-by: kgeckhart <kgeckhart@users.noreply.github.com> Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Co-authored-by: kgeckhart <kgeckhart@users.noreply.github.com> Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
thepalbi
force-pushed
the
pablo/make-library-friendly
branch
from
24ec49f to
d24d5cd
Compare
SuperQ
reviewed
May 19, 2022
Contributor
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Minor comment about the gitignore.
Contributor
|
We've talked about making more of our exporter collector packages interchangeable to allow more library use. We're trying to come up with a registration/config pattern for this. If you're interested in contributing, I would love to hear your thoughts. |
Signed-off-by: Pablo Balbi <pablo.l.balbi@gmail.com>
Contributor
Author
Definetely, feel free to tag me in any issue/thread were you are discussing. More than happy to contribute 😀 |
Contributor
|
I didn't find an issue for it, so I opened prometheus/exporter-toolkit#92. |
SuperQ
pushed a commit
that referenced
this pull request
Nov 22, 2022
This PR introduces support for aggregating DELTA metrics in-memory. This implementation is somewhat based on #167 but with extra functionality which is intended to solve the problem identified here, #167 (comment). I chose to inject interfaces for the delta and distribution stores at the Collector level to try to keep library friendliness intact, #157 I did as much as I could to explain the solution and the tradeoffs with aggregating deltas in this manner in the README.md. The bulk of the changes are in `monitoring_metrics.go` where I tried to obfuscate as much of the delta logic as possible. Should hopefully resolve #116 and #25 Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to use stackdriver_exporter as a library. The project is almost usable as a library as it is, though inside the main collectors code (
MonitoringCollector) some CLI flag are used from the global context.This PR does a couple of changes to make
MonitoringCollectormore suitable for library use:kingpinCLI flags in a same fileflags.go. This cleans the packagecollectors, making it only content the actual collector's code.MonitoringCollectorOptions, which will be used to send the newly created collector all required settings.monitoring.metrics-type-prefixesandmonitoring.filtersto themainpackage. Also for cleaning up thecollectorspackage.