Refactor delta logic for library usage#190
Merged
SuperQ merged 6 commits intoprometheus-community:masterfrom Dec 19, 2023
Merged
Refactor delta logic for library usage#190SuperQ merged 6 commits intoprometheus-community:masterfrom
SuperQ merged 6 commits intoprometheus-community:masterfrom
Conversation
kgeckhart
force-pushed
the
keckhart/delta-library-usage
branch
3 times, most recently
from
c60e1f5 to
7748675
Compare
Contributor
|
This needs a rebase. |
kgeckhart
force-pushed
the
keckhart/delta-library-usage
branch
from
7748675 to
95ff3ad
Compare
SuperQ
reviewed
Jun 9, 2023
matthiasr
approved these changes
Jun 19, 2023
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
… histogram Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
…imeSeriesMetrics Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
kgeckhart
force-pushed
the
keckhart/delta-library-usage
branch
from
ab619ab to
dabdb3d
Compare
Contributor
Author
|
@SuperQ could you take another look? |
SuperQ
approved these changes
Dec 19, 2023
Contributor
|
Sorry for the review delays, this exporter got lost in my inbox. |
Merged
SuperQ
added a commit
that referenced
this pull request
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #168 after attempting to use the collector in a library and realizing there were some issues with some fields needing to be exported on HistogramMetric and ConstMetric to make it work.
I noticed a few other things which I fixed up along the way
I have another follow up to this which abstracts the the store implementation so it can be shared between Histograms and Counters but didn't want to pile too many things in to this.