Add etcd notifier#1003
Closed
dtnaylor wants to merge 1 commit intoprometheus:masterfrom
nefeli:etcd_notifier
Closed
Add etcd notifier#1003dtnaylor wants to merge 1 commit intoprometheus:masterfrom nefeli:etcd_notifier
dtnaylor wants to merge 1 commit intoprometheus:masterfrom
nefeli:etcd_notifier
Conversation
Contributor
|
Thanks for the pr! As you noticed, we're not actively adding notifiers at the moment as we try to figure out something more flexible. For the time being, we recommend implementing custom notifiers via the webhook notifier. |
Author
|
Great, we'll stay tuned to see what you come up with :) In case it helps your planning, the two things we need in this case that the webhook notifier doesn't (currently) offer are (1) the ability to add custom keys to the POSTed JSON and (2) the ability to base64 encode the values (maybe base64encode could be added as a template function for Prometheus alerts?). |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Aug 5, 2018
It is quite common to put /var/lib/docker itself on a separate partition and that should be monitored as well. Signed-off-by: Johannes Wienke <languitar@semipol.de>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
May 25, 2019
* Fix ordering of CHANGE items by PR number. * Add missing CHANGE for prometheus#1003 Signed-off-by: Ben Kochie <superq@gmail.com>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Jun 2, 2019
* Fix ordering of CHANGE items by PR number. * Add missing CHANGE for prometheus#1003 Signed-off-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add notifier that puts/deletes keys in an etcd KV store using etcd's grpc-gateway.
I’m not sure how much demand for this there is, so if you don’t think it’s worth supporting, then consider this a +1 for #701.
A sample configuration:
And a sample rule: