Add Slack additional "fields" to notifications #1135
Merged
stuartnelson3 merged 2 commits intoprometheus:masterfrom Dec 15, 2017
rbtr:slack-fields
Merged
Add Slack additional "fields" to notifications #1135stuartnelson3 merged 2 commits intoprometheus:masterfrom rbtr:slack-fields
stuartnelson3 merged 2 commits intoprometheus:masterfrom
rbtr:slack-fields
Conversation
Contributor
stuartnelson3
left a comment
stuartnelson3
left a comment
There was a problem hiding this comment.
looks good. could you fix the merge conflicts?
notify/impl.go
Outdated
| var fields = make([]slackAttachmentField, numFields) | ||
| for k, v := range n.conf.Fields { | ||
| fields[k] = slackAttachmentField{ | ||
| v["title"], |
Contributor
There was a problem hiding this comment.
let's add tmplText() around both title and value, so the users can optionally define a template
rbtr
commented
Dec 14, 2017
| fields[k] = slackAttachmentField{ | ||
| v["title"], | ||
| v["value"], | ||
| tmplText(v["title"]), |
stuartnelson3
approved these changes
Dec 15, 2017
Contributor
Author
|
Closes #731 |
|
This capability isn't documented anywhere on the Prometheus website, despite the latest release being from 13 days ago. see: https://prometheus.io/docs/alerting/configuration/#%3Cslack_config%3E Am I looking in the wrong place, or should the documentation be updated? |
Contributor
Author
|
@JeanMertz i think the doc just needs to be updated. i'll see if i can contrib that |
Contributor
|
@JeanMertz @rbtr yeah the docs need to be updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a go at implementing #731