Skip to content

feat: support dingtalk notification#1276

Closed
halfcrazy wants to merge 1 commit intoprometheus:masterfrom
halfcrazy:feat/support_dingtalk
Closed

feat: support dingtalk notification#1276
halfcrazy wants to merge 1 commit intoprometheus:masterfrom
halfcrazy:feat/support_dingtalk

Conversation

@halfcrazy
Copy link

@halfcrazy halfcrazy commented Mar 6, 2018

DingTalk is a Chinese enterprise IM. Integrated DingTalk via webhook description at https://open-doc.dingtalk.com/docs/doc.htm?spm=a219a.7629140.0.0.2aYysA&treeId=257&articleId=105735&docType=1

FIX #665

@simonpasquier
Copy link
Member

As you can read in the Prometheus documentation, the project doesn't accept new receivers. In case you didn't know already, there's an existing webhook to DingTalk project: https://github.com/timonwong/prometheus-webhook-dingtalk

@halfcrazy halfcrazy closed this Mar 6, 2018
@xizhibei
Copy link

xizhibei commented Mar 18, 2018

Hi, @simonpasquier, I would like to request you to accept this PR. (Actually I am also developing my own version[1], but this one also works)

First, as @berlinsaint said in #1059:

Wechat In Chinese have a huge number users. Not Every users know webhook or implement the webhook notification. I strongly recommend to merge this contribute. All the notifier's in alertmanger now is never used in chinese .BTW i think alertmanger will get more users in chinese, this is good things ,right?

DingTalk[2] is the main competitor to Wechat Corp Version (And maybe DingTalk is the No.1 ), and Dingtalk already reachs users to 100 million[3]. There is no reason you accept WechatCorp but not for Dingtalk. You accept the PR, you gain 80%(or maybe more) of Chinese users.

Second, the "prometheus-webhook-dingtalk" is not convenient for developer to setup, since it is a independent component and It is facing the high available problem, we have to deploy at least 3 of it, which increasing the complexity to deploy. Accept this PR, you do great favor to Chinese Developers, thanks in advance :P

And last, I understand your concerns about too many receivers will make alertmanager hard to maintain, so if you still not accept this PR, would you like to consider develop plugin system, so that we can easily add any receivers ?

[1]. https://github.com/xizhibei/alertmanager/tree/dingtalk-notify
[2]. https://www.dingtalk.com/en/download
[3]. https://medium.com/dingtalk/dingtalk-a-product-by-alibaba-reaches-100-million-users-ee693d381734

@brian-brazil
Copy link
Contributor

if you still not accept this PR, would you like to consider develop plugin system, so that we can easily add any receivers ?

The webhook is the plugin system.

@xizhibei
Copy link

Thanks for reply, but I mean the plugin system like the one in elastalert: https://elastalert.readthedocs.io/en/latest/recipes/adding_alerts.html, you write your own code, integrated in one process, and easy to deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants