dispatch: don't reset timer if flush is in-progress#1301
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom Mar 29, 2018
Merged
dispatch: don't reset timer if flush is in-progress#1301stuartnelson3 merged 1 commit intoprometheus:masterfrom
stuartnelson3 merged 1 commit intoprometheus:masterfrom
Conversation
When the aggregation group receives an alert that is past the initial group_wait value, it should reset its timer only if the timer has ever expired. Otherwise it means that the flush is already in-progress.
stuartnelson3
approved these changes
Mar 29, 2018
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
May 5, 2018
When the aggregation group receives an alert that is past the initial group_wait value, it should reset its timer only if the timer has ever expired. Otherwise it means that the flush is already in-progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps a bit for #1005 but it isn't a silver bullet.