ui: replace deprecated InstrumentHandler()#1302
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom Mar 28, 2018
Merged
ui: replace deprecated InstrumentHandler()#1302stuartnelson3 merged 1 commit intoprometheus:masterfrom
stuartnelson3 merged 1 commit intoprometheus:masterfrom
Conversation
This change replaces the deprecated InstrumentHandler function by the equivalent functions from the promhttp package. The following metrics are removed: * http_request_duration_microseconds (Summary). * http_request_size_bytes (Summary). * http_requests_total (Counter). And the following metrics are added instead: * alertmanager_http_request_duration_seconds (Histogram). * alertmanager_http_response_size_bytes (Histogram). * promhttp_metric_handler_requests_in_flight (Gauge). * promhttp_metric_handler_requests_total (Counter).
Contributor
stuartnelson3
left a comment
stuartnelson3
left a comment
There was a problem hiding this comment.
Looks good. Question on the naming:
Why did you use alertmanager_http_request_duration_seconds in this PR, but in the prometheus PR you used http_request_duration_seconds?
Contributor
|
It's prometheus_http_request_duration_seconds in Prometheus. |
stuartnelson3
approved these changes
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is similar to prometheus/prometheus#3862. It should probably wait for v0.15.0 to be out.
The following metrics are removed:
And the following metrics are added instead: