Rename silence API Delete() -> Expire()#1319
Merged
stuartnelson3 merged 1 commit intomasterfrom Apr 11, 2018
Merged
Conversation
Member
|
LGTM except you need to sign your commit to please the DCO check ;-) |
mxinden
approved these changes
Apr 11, 2018
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
For sure a better description 👍
Within alertmanager, expire is the term used, since silences still "exist" but aren't in effect. Signed-off-by: Stuart Nelson <stuartnelson3@gmail.com>
stuartnelson3
force-pushed
the
stn/rename-silence-client-delete
branch
from
21bb582 to
7391e4d
Compare
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
May 5, 2018
Within alertmanager, expire is the term used, since silences still "exist" but aren't in effect. Signed-off-by: Stuart Nelson <stuartnelson3@gmail.com>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
May 7, 2019
Avoid 32-bit counter rollovers. Signed-off-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within alertmanager, expire is the term used,
since silences still "exist" but aren't in effect.