notify: remove wechat unit test#1350
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom Apr 30, 2018
Merged
Conversation
The unit test was making a request to the public Wechat endpoint which caused flaky results. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
remove-wechat-test
branch
from
9d6da3c to
9fa1e8b
Compare
Member
|
👍 Sad to not have any test coverage for the WeChat provider, but better than doing a call to a live system in a unit test. |
Contributor
|
True. But, part of the deal for adding wechat was that someone using it would maintain it. If it gets in the way of the rest of our test suite, the onus is on them. |
Member
|
Aggreed, thanks for investigating.
…On Mon, 30 Apr 2018, 20:01 stuart nelson, ***@***.***> wrote:
Merged #1350 <#1350>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1350 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGuKs5MtqW9g1qr5WtXOKnQKzQ87jlq6ks5tt1GFgaJpZM4TsvtX>
.
|
Member
|
/cc @berlinsaint |
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
May 5, 2018
The unit test was making a request to the public Wechat endpoint which caused flaky results. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1348.