Update alerts argument order, rename expired to inhibited#1360
Merged
stuartnelson3 merged 1 commit intomasterfrom May 4, 2018
Merged
Update alerts argument order, rename expired to inhibited#1360stuartnelson3 merged 1 commit intomasterfrom
stuartnelson3 merged 1 commit intomasterfrom
Conversation
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
stuartnelson3
force-pushed
the
stn/cli-silenced-inhibited-arg-order
branch
from
25eb3fb to
baf39ce
Compare
Member
|
👍 |
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
May 5, 2018
…#1360) Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expiredtoinhibitedsilencedandinhibitedwas reversed (cf. https://github.com/prometheus/alertmanager/blob/master/client/client.go#L155-L160)the API is not properly filtering responses, but that's for a different PR.
@simonpasquier