cluster: advertise explicitly for empty addresses#1386
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom Jun 7, 2018
Merged
cluster: advertise explicitly for empty addresses#1386stuartnelson3 merged 1 commit intoprometheus:masterfrom
stuartnelson3 merged 1 commit intoprometheus:masterfrom
Conversation
memberlist doesn't advertise a valid IP address when the bind address is
empty (":8001") or the unspecified IPv6 address ("[::]:8001).
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
stuartnelson3
approved these changes
Jun 7, 2018
Contributor
|
sorry for the delay, re-running test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing #1384 I found that the address advertised by memberlist isn't valid when the bind address is empty. cc @stuartnelson3