*: remove dependency on github.com/prometheus/prometheus#2009
Merged
simonpasquier merged 1 commit intoprometheus:masterfrom Sep 16, 2019
Merged
*: remove dependency on github.com/prometheus/prometheus#2009simonpasquier merged 1 commit intoprometheus:masterfrom
simonpasquier merged 1 commit intoprometheus:masterfrom
Conversation
codesome
approved these changes
Aug 27, 2019
Member
codesome
left a comment
codesome
left a comment
There was a problem hiding this comment.
Took a quick look, and LGTM! I like this removal of dependency on Prometheus.
Contributor
|
Once we unify the two labels packages, we might want to kick this to common. |
Member
Author
I thought we were going away from common. |
simonpasquier
force-pushed
the
remove-prometheus-dep
branch
from
92ef759 to
a6eb8e8
Compare
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
remove-prometheus-dep
branch
from
a6eb8e8 to
1fa2a00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We depend on the Prometheus repository only for the
github.com/prometheus/prometheus/pkg/labelspackage and from this package, we use only theMatcherstruct.Knowing that this code hasn't evolved for years now, it seems safe and simpler to duplicate it in AlertManager rather than the heavy dependency we have right now (see #2008). In addition Prometheus has an indirect dependency on
github.com/hashicorp/memberlistand many other Hashicorp libs which can cause version changes whenever we need to bump github.com/prometheus/prometheus.