Skip to content

Fix empty isEqual in amtool.#2668

Merged
roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie:amtool-silence
Aug 6, 2021
Merged

Fix empty isEqual in amtool.#2668
roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie:amtool-silence

Conversation

@roidelapluie
Copy link
Member

This is the best we can do to make amtool support old releases.

Supersedes #2634
Fix #2666

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

This is the best we can do to make amtool support old releases.

Supersedes prometheus#2634
Fix prometheus#2666

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
@roidelapluie
Copy link
Member Author

cc @gotjosh

Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gotjosh
Copy link
Member

gotjosh commented Aug 5, 2021

Supersded by #2669

@roidelapluie
Copy link
Member Author

We would need this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Querying silences throws format matcher errors for -o simple and -o extended

2 participants