Export ValidateMatcher for DI (#2)#2716
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Oct 21, 2021
grafana:matcherValidation2
Merged
Export ValidateMatcher for DI (#2)#2716roidelapluie merged 1 commit intoprometheus:mainfrom grafana:matcherValidation2
roidelapluie merged 1 commit intoprometheus:mainfrom
grafana:matcherValidation2
Conversation
so third parties, Grafana in particular, can over ride the validation. Grafana wants to do this because other data sources will have label keys with things like spaces, periods, or other characters - and looking for a better integration with alert manager. goes with grafana/grafana#38629 replaces #2694 Signed-off-by: Kyle Brandt <kyle@grafana.com>
Member
|
is that the only way to do this? exporting a function as global variable is not that great. |
Contributor
Author
Perhaps it come be done so Does that sound better? |
roidelapluie
approved these changes
Oct 21, 2021
Member
roidelapluie
left a comment
roidelapluie
left a comment
There was a problem hiding this comment.
Thanks, note that if you allow dots, you should not allow ... as label name because it's special in alertmanager
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
so third parties, Grafana in particular, can over ride the validation. Grafana wants to do this because other data sources will have label keys with things like spaces, periods, or other characters - and looking for a better integration with alert manager. goes with grafana/grafana#38629 replaces prometheus#2694 Signed-off-by: Kyle Brandt <kyle@grafana.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
so third parties, Grafana in particular, can over ride the validation. Grafana wants to do this because other data sources will have label keys with things like spaces, periods, or other characters - and looking for a better integration with alert manager. goes with grafana/grafana#38629 replaces prometheus#2694 Signed-off-by: Kyle Brandt <kyle@grafana.com> Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So third parties, Grafana in particular, can override the validation.
Grafana wants to do this because other data sources will have label keys with things like spaces, periods, or other characters - and looking for a better integration with alert manager.
goes with grafana/grafana#38629
replaces #2694 with more minimal changes, as most of that was able to be moved into Grafana's code base.