Skip to content

fix lint error#2785

Merged
simonpasquier merged 1 commit intoprometheus:mainfrom
clyang82:fix_lint
Dec 17, 2021
Merged

fix lint error#2785
simonpasquier merged 1 commit intoprometheus:mainfrom
clyang82:fix_lint

Conversation

@clyang82
Copy link
Contributor

@clyang82 clyang82 commented Dec 9, 2021

There are new rules defined in https://github.com/grafana/dashboard-linter. some of rules are strict. so add them into exclusions.

Signed-off-by: clyang82 chuyang@redhat.com

@clyang82
Copy link
Contributor Author

clyang82 commented Dec 9, 2021

wait for this PR - grafana/dashboard-linter#10 to fix the remaining lint error

Signed-off-by: clyang82 <chuyang@redhat.com>
@clyang82
Copy link
Contributor Author

/assign @roidelapluie mixin cannot be passed due to the latest changes in github.com/monitoring-mixins/mixtool This PR is to fix the failure.

Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonpasquier simonpasquier merged commit 5fa473c into prometheus:main Dec 17, 2021
@simonpasquier
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants