api/v2: Delete silence respond with 404 when silence is not found#2815

Closed

hateeyan wants to merge 1 commit intoprometheus:mainfrom

hateeyan:silence_delete

hateeyan commented Jan 12, 2022

Hi,
When a client attempts to delete a non-existent silence, respond with 404 instead of 500.

Signed-off-by: hateeyan hateeyan@gmail.com


          api/v2: Delete silence respond with 404 when silence is not found

ae37b9a

Signed-off-by: hateeyan <hateeyan@gmail.com>

soonping-amzn mentioned this pull request

Return no error when deleting expired silence #2817

Merged

simonpasquier approved these changes

View reviewed changes

Member

simonpasquier left a comment

lgtm

Contributor

rohang98 commented Apr 18, 2023 •

edited

Loading

@simonpasquier @hateeyan can this be merged?

Contributor

emanlodovice commented May 3, 2023

I tried rebasing this to main and it seems like there are test failures, @hateeyan can you rebase this add fix the failures? Thank you.

emanlodovice mentioned this pull request

api/v2: Delete silence respond with 404 when silence is not found #3352

Merged

Author

hateeyan commented May 4, 2023

@rohang98 @emanlodovice
Another related PR(#2817) has been merged which repond with 200 when silence is not found.
I suppose that this PR is no longer needed.

jeromeinsf commented May 4, 2023

is expired silence the same thing as not found silence?

Contributor

emanlodovice commented May 4, 2023

@hateeyan I think the PR is still needed because expired silence is not the same as not found silence. I created another PR that rebases this PR yesterday. #3352

hateeyan closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet