Adding telegram support by timmilesdw · Pull Request #2827 · prometheus/alertmanager

timmilesdw · 2022-02-04T06:01:05Z

Added telegram integration

Features:

Custom API URL
Disable Notifications
Message templating

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw · 2022-02-04T09:04:11Z

@w0rm

w0rm · 2022-02-04T20:21:48Z

@timmilesdw @SuperQ sorry folks, I can’t review the go code! Happy to review the UI anytime though 😅

timmilesdw · 2022-02-05T18:04:03Z

Oh, sorry, i had no clue about it. @SuperQ can you please revoke review request from w0rm? I should probably mention @simonpasquier instead

config/notifiers.go

docs/configuration.md

notify/telegram/telegram.go

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

…hanged message truncation to 4096 chars Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw · 2022-02-07T09:34:17Z

the test is failing, but i don't see that i affect the TestClusterDeduplication test, maybe someone could rerun tests?

metalmatze · 2022-02-07T14:12:00Z

This looks amazing and I'd love to see this being added to alertmanager itself!
Since the alertmanager-bot only ever supported Telegram and only few of the chat commands really are used, I'd be happy to sunset/deprecate the bot in-favor if this implementation.

cmd/alertmanager/main.go

config/notifiers.go

docs/configuration.md

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw · 2022-02-07T15:54:22Z

Could someone rerun frontend test? Failed because it can't pull image from dockerhub

metalmatze · 2022-02-09T17:25:08Z

Anything left to do here in order to merge? Amazing work!

timmilesdw · 2022-02-09T20:08:24Z

Anything left to do here in order to merge? Amazing work!

Thanks! @simonpasquier any updates?

timmilesdw · 2022-02-22T16:22:10Z

Comment for activity, waiting for merge or re-review

simonpasquier · 2022-02-22T16:49:54Z

Chatted offline with @metalmatze who's willing to help with maintaining this integration so this is a 👍 for me too.

simonpasquier · 2022-02-22T16:51:08Z

Thanks!

timmilesdw · 2022-02-22T16:51:42Z

Great! Thank you too!

chanyshev · 2022-05-07T11:21:58Z

I have chat_id negative number and I see this error
"Notify attempt failed, will retry later" attempts=1 err="telegram: Bad Request: can't parse entities: Character '-' is reserved and must be escaped with the preceding '\\' (400)"
udp:
The problem turned out to be in the parameter parse_mode:
I changed to HTML and the messages started coming.
How to use parse_mode: MarkdownV2 ?

tazhate · 2022-05-19T14:07:50Z

HOLY MOLY! Thanks a lot for this MR!

timmilesdw added 8 commits February 4, 2022 11:05

added telegram config in notifiers

f0eed9b

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

added telegram config to config.go

d09a414

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

added package telegram to notify and initialization in cmd

28e7f3a

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

added telegram.default.message

fc16a1f

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

added telegram template to notifiers.go

ba40e58

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

added message rendering from template to telegram integration

7ce20ae

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

documentation for telegram_configs

a1393c2

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

added tests for telegram

b52fdac

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw force-pushed the telegram-integration branch from 0d0d107 to b52fdac Compare February 4, 2022 06:06

fixed config_test.go

8e365cd

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw changed the title ~~Telegram support~~ Adding telegram support Feb 4, 2022

SuperQ requested review from simonpasquier and w0rm February 4, 2022 17:34

SuperQ requested review from gouthamve and matthiasr and removed request for w0rm February 6, 2022 11:11

matthiasr reviewed Feb 6, 2022

View reviewed changes

config/notifiers.go Outdated Show resolved Hide resolved

docs/configuration.md Show resolved Hide resolved

notify/telegram/telegram.go Outdated Show resolved Hide resolved

notify/telegram/telegram.go Show resolved Hide resolved

notify/telegram/telegram.go Show resolved Hide resolved

timmilesdw added 4 commits February 7, 2022 12:12

added valid parse_mode list to the error log

b884e06

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

made use of httpconfig, moved telegram client creation to New func, c…

e039834

…hanged message truncation to 4096 chars Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

changed supported values for telegram config

7984905

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

added mock url for telegram tests to pass

fe86e87

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw requested a review from matthiasr February 7, 2022 09:29

simonpasquier reviewed Feb 7, 2022

View reviewed changes

cmd/alertmanager/main.go Outdated Show resolved Hide resolved

config/notifiers.go Show resolved Hide resolved

config/notifiers.go Outdated Show resolved Hide resolved

docs/configuration.md Show resolved Hide resolved

timmilesdw added 2 commits February 7, 2022 20:12

added api_url check to telegram config

c431bfb

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

changed bot_token type to secret

0993989

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw added 5 commits February 7, 2022 20:33

removed extra emptyline

f5ef565

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

convert bot_token to string in telegram client creation

256ba76

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

updated configuration.md

fef2437

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

fixed mixed up errors

15576d8

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

check telegram api url without conversion to string

d7a3829

Signed-off-by: timmilesdw <tuktamyshev.t0308@gmail.com>

timmilesdw requested a review from simonpasquier February 7, 2022 15:54

simonpasquier merged commit 1138a08 into prometheus:main Feb 22, 2022

sengaya mentioned this pull request Mar 30, 2022

Add MS Teams webhook support #1021

Closed

gotjosh mentioned this pull request Apr 11, 2022

notify/telegram: Set API URL and ParseMode defaults #2879

Closed

JohnVillalovos mentioned this pull request Dec 30, 2022

How to Alertmanager running shell-script #2046

Closed

Conversation

timmilesdw commented Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timmilesdw commented Feb 4, 2022

Uh oh!

w0rm commented Feb 4, 2022

Uh oh!

timmilesdw commented Feb 5, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timmilesdw commented Feb 7, 2022

Uh oh!

metalmatze commented Feb 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timmilesdw commented Feb 7, 2022

Uh oh!

metalmatze commented Feb 9, 2022

Uh oh!

timmilesdw commented Feb 9, 2022

Uh oh!

timmilesdw commented Feb 22, 2022

Uh oh!

simonpasquier commented Feb 22, 2022

Uh oh!

simonpasquier commented Feb 22, 2022

Uh oh!

timmilesdw commented Feb 22, 2022

Uh oh!

chanyshev commented May 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tazhate commented May 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

timmilesdw commented Feb 4, 2022 •

edited

Loading

chanyshev commented May 7, 2022 •

edited

Loading