Handle errors in Slack's postMessage API#3160
Closed
carlpett wants to merge 1 commit intoprometheus:mainfrom
Closed
Handle errors in Slack's postMessage API#3160carlpett wants to merge 1 commit intoprometheus:mainfrom
carlpett wants to merge 1 commit intoprometheus:mainfrom
Conversation
For larger organisations, using the postMessage API has advantages over webhooks, such as not being tied to a specific user (who might leave the company at some point, resulting in the webhook integration becoming disabled), and posting to multiple channels. Alertmanager's Slack integration actually works with this endpoint out of the box, by setting the URL path to /api/chat.postMessage. However, error handling works a bit differently on this endpoint, always returning 200 OK even when the posted message is rejected. This commit handles the response format from this endpoint, so that errors are reported correctly.
Contributor
|
This seems like a duplicate of #3121. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For larger organisations, using the postMessage API has advantages over webhooks, such as not being tied to a specific user (who might leave the company at some point, resulting in the webhook integration becoming disabled), and posting to multiple channels.
Alertmanager's Slack integration actually works with this endpoint out of the box, by setting the URL path to /api/chat.postMessage. However, error handling works a bit differently on this endpoint, always returning 200 OK even when the posted message is rejected.
This commit handles the response format from this endpoint, so that errors are reported correctly.
Note for the review: This doesn't seem like a super-elegant approach, so very open for opinions on other ways to structure this.