Github actions

[jan--f]

This is a first draft to move from CircleCI to Github Actions.
Generally I tried to trigger workflows only for relevant changes, e.g. the mixin-lint is only triggered if a file in the mixins change.

Two things are tbd:

1. This doesn't yet store the frontend asset tarball anywhere. I wasn't exactly sure how this is currently handled in the CircleCI setup, any pointer are appreciated.
2. This currently uses my fork of maildev at https://github.com/jan--f/maildev/tree/hide-starttls-when-user-password, which simply re-enables STARTTLS, which was disabled in v1.1.1. There is a PR up that looks promising in order for Alertmanager to switch back to upstream maildev. The current PR version doesn't work, since I believe it no longer sets up self-signed certificates. Otoh we could simply create those certs ourselves and pass them via the proposed arguments. This still requires a fix to maildev, see Add option to enabe/disable hideSTARTTLS maildev/maildev#469. So I'll keep my forked image in here for now.

Looking forward to any feedback.

[jan--f]

cc @roidelapluie

[simonpasquier]

This doesn't yet store the frontend asset tarball anywhere. I wasn't exactly sure how this is currently handled in the CircleCI setup, any pointer are appreciated.

The test_frontend job will persist the tarball in the workflow's workspace at the same directory (e.g. .tarballs ) where the binaries will be generated. When running promu release ..., everything will be uploaded to the release page (https://github.com/prometheus/alertmanager/releases/tag/v0.26.0).

I believe that we need to use ./.github/promci/actions/save_artifacts and ./.github/promci/actions/restore_artifacts.

[jan--f]

This is currently blocked by actions/runner#2783.

[jan--f]

I believe that we need to use ./.github/promci/actions/save_artifacts and ./.github/promci/actions/restore_artifacts.

Thanks! I added ./.github/promci/actions/save_artifacts to the test_frontend job. ./.github/promci/actions/restore_artifacts is then used by the ./.github/promci/actions/publish_[main|release] actions in the publish and release workflows.

[gotjosh]

Hey @jan--f can you walk me through the how is this blocked by actions/runner#2783?

[jan--f]

@gotjosh sure thing. This intends to run maildev as a service containers.
If you look at the action runs in my clone, the maildev related tests complain about not being able to resolve the service container. according to the docs, this should work exactly as specified though. actions/runner#2783 describes exactly that.

[gotjosh]

@jan--f I think we shouldn't block this migration on these tests.

My suggestion is that you can add a new make command that runs all of the excepts except the ones in email_tests.go (we'll run both test suites in parallel for some time before cutting over anyways) and I'll be happy to change the tests to run the container as part of the tests directly (this is something we rely on heavily in mimir).

What do you think?

[jan--f]

@gotjosh yeah that sounds good. Happy to take stab at pulling maildev into the test myself if you're not already working on it. We probably still want maildev/maildev#469 though? Or simply keep using the ancient version like in the existing tests?

[gotjosh]

LGTM

[gotjosh]

We rarely touch the mixin, but we find out from time to time that something in the ecosystem has been broken and fix it - I believe we should always run it as this is not a very time consuming workflow.