feat(discord): add global and secret file for discord notifier#3308
Closed
budimanjojo wants to merge 1 commit intoprometheus:mainfrom
budimanjojo:main
Closed
feat(discord): add global and secret file for discord notifier#3308budimanjojo wants to merge 1 commit intoprometheus:mainfrom budimanjojo:main
budimanjojo wants to merge 1 commit intoprometheus:mainfrom
budimanjojo:main
Conversation
Member
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
We need to check that both DiscordWebhookURL and DiscordWebhookURLFile aren't defined at the same time in the global section.
Member
|
I'm not sure about the CircleCI error but could you try rebasing your PR on top of main? Adding some unit tests would be appreciated too (you can look at notify/opsgenie/opsgenie_test.go for inspiration). |
Author
|
sorry I messed up the rebase rofl. I'm trying |
Signed-off-by: budimanjojo <budimanjojo@gmail.com>
Author
|
is this good now? |
simonpasquier
approved these changes
Jun 2, 2023
Contributor
|
This feature was introduced by #3555 |
Author
|
Thanks for the information @LucaDev! Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enable the ability for
discordnotifier to use a file instead of plain secret.This also adds the
global.discord_webhook_urlandglobal.discord_webhook_url_file