Add support for pushover devices#3318
Merged
gotjosh merged 2 commits intoprometheus:mainfrom May 5, 2023
Merged
Conversation
alec-pinson
force-pushed
the
feat/support-pushover-device
branch
from
2c566a6 to
05d2da7
Compare
5 tasks
Contributor
Author
|
Hi, @simonpasquier @w0rm @gotjosh can one of you review this when you get chance please, it's a simple addition and I've tested it, thanks 😃. |
Member
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you also update the documentation in docs/configuration.md?
Am I correct in assuming that when device is empty then the notification is sent to all devices?
Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
alec-pinson
force-pushed
the
feat/support-pushover-device
branch
from
57995d7 to
53cbb72
Compare
Contributor
Author
You are correct! |
Member
|
Anything else @simonpasquier ? |
gotjosh
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Add support for pushover devices Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com> * update docs Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com> --------- Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
2 tasks
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
* Add support for pushover devices Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com> * update docs Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com> --------- Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending Pushover integration to allow for
deviceparameter to be used.https://pushover.net/api#device