Merged
Conversation
This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/add-tests-for-matchers
branch
from
d052d40 to
101f7bb
Compare
gotjosh
approved these changes
May 12, 2023
Member
gotjosh
left a comment
gotjosh
left a comment
There was a problem hiding this comment.
Nice work! LGTM but please see my comments.
pkg/labels/parse_test.go
Outdated
| err: `bad matcher format: {foo=`, | ||
| }, | ||
| { | ||
| // This looks like a bug which should be fixed |
Member
There was a problem hiding this comment.
Suggested change
| // This looks like a bug which should be fixed |
Member
There was a problem hiding this comment.
I suggest we don't leave these tasks as comments in the code and instead either: a) open individual PRs to fix them or b) keep them in your task list of things to do so that we can discuss them individually.
pkg/labels/parse_test.go
Outdated
| }(), | ||
| }, | ||
| { | ||
| // This also looks like a bug which should be fixed |
Member
There was a problem hiding this comment.
Suggested change
| // This also looks like a bug which should be fixed |
gotjosh
approved these changes
May 12, 2023
Member
gotjosh
left a comment
gotjosh
left a comment
There was a problem hiding this comment.
Nice work! LGTM but please see my comments.
Signed-off-by: George Robinson <george.robinson@grafana.com>
Member
|
Thank you very much for this contribution. |
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jun 6, 2023
* Add tests to TestMatchers This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jul 5, 2023
* Add tests to TestMatchers This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jul 6, 2023
* Add tests to TestMatchers This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jul 7, 2023
* Add tests to TestMatchers This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
gotjosh
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Add tests to TestMatchers This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
* Add tests to TestMatchers This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
qinxx108
pushed a commit
to amazon-contributing/alertmanager
that referenced
this pull request
Mar 28, 2024
* Add tests to TestMatchers This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers. Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a number of tests to TestMatchers that asserts some of the more nuanced behavior when parsing label matchers.